[PoolTracker] Add saving and redirecting to last seen pool post #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of just latest post)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to the pool tracker to save the last seen pool post, and inform the user how many posts behind they are and redirects them to their latest seen pool post, instead of just the latest pool post (useful for when you're multiple posts behind)
Currently this redirects the user to their own latest seen pool post, however if you wish I can change this to instead show the latest unseen post. However I feel like currently it is adequate enough without adding too much complexity.
I've been using this branch for almost two weeks now, and I'm pretty sure I've ironed out any bugs, and put in fixes for edge cases. Please tell me if you come across anything else that should be fixed :)
Also, on a side note: It was also my intention of adding this type of functionality to the forum tracker as well (using # in the url to highlight new posts), however the API request doesn't give any ID of the latest forum post so there's not much I can do unless I add extra API requests