[SearchUtilities] Add setting to change how the searchbar cursor focuses on hotkey #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added checkbox option in settings menu to switch cursor behavior Implemented the behavior in the event handler
This is my first time doing TypeScript
Previous method didn't work with triggering focus at first.
Current implementation doesn't work, need to do some more digging with how the event handler and its dependencies work.
The setting can't be pulled from inside the event handler, so I'll have to create two separate event handlers and find a way to switch between them.
Ended up not needing multiple event handlers. I could simply pass in a module-level variable that gets set by the Settings value, which I could then read inside the single event handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #366
Adds a checkbox setting in General -> Sidebar to toggle between original re621 behavior (focusing the cursor to the beginning of the query) and vanilla e621 behavior (focusing the cursor to the end of the query).
Adds implementation of behavior switching within event handler.