Janky solution to show blacklist exceptions #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a blacklisted post has an exception (whitelist, favorite, or user upload), this solution shows the post on initial load on the post page. It does not recognize that the post isn't "blacklisted" because of the exception, and disabling/re-enabling the active filter re-hides the post.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a blacklisted post has an exception (whitelist, favorite, or user upload), this solution shows the post on initial load on the post page. It does not recognize that the post isn't "blacklisted" because of the exception, and disabling/re-enabling the active filter re-hides the post.
Ideally, this would use the
BlacklistEnhancermodule so that the blacklist UI in the sidebar could be handled, as well as any parent/child posts that also have exceptions. However, that would require overhauling the module to allow it to also be present on Post pages, which would in turn require a similar overhaul for theBetterSearchmodule since the two are dependent on each other. This works as an ugly stopgap in the meantime, but any guidance for making it more robust would be appreciated.Resolves #390