Add peer dependency for React 18 in visually-hidden package
#953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 496cfd8:
|
cassidoo
changed the title
visually-hidden package
|
I get this a lot for the other reach packages too, not just visually-hidden. This might be more of a @chaance thing though, I'm not so much involved. |
|
Good to know @bradwestfall! I figured Chance might be the person to ping on this but wasn't sure 😅 |
|
For reference there is still a lot of testing needed for React 18 in general (tracking here). This one is safe to update though so I'll merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey team, right now if you install this package with a fresh React 18 project, you get a
ERESOLVE unable to resolve dependency treeand I made this small change so that not everyone needs to do the whole--legacy-peer-depsthing.I can update it to
>=16.8instead of adding the||if you'd prefer, too, and add other packages as well, but I started small in case there might be a reason to not do this.This pull request: