Play nicely with react-hot-loader #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this getting merged anytime soon ? |
react-hot-loader's component proxying was breaking direct comparisons with the `Redirect` component type. Fix this using a suggested approach from gaearon/react-hot-loader#304.
pugnascotia
force-pushed
the
support-hot-reloading
branch
from
2279a89
to
20e3095
Compare
|
Rebased on latest master. |
|
I'm not part of this project, but you might have a better chance of it being merged if there were some tests? |
|
For those landing here with the same issue related to TLDR; use "path" instead of "from" in the |
|
More conservatively, this could do the "static member" strategy, if there's any fear of breakage here. Just ran in to a production bug with this, where the warning/error did not show up in development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-hot-loader's component proxying was breaking direct comparisons with the
Redirectcomponent type. Fix this using a suggested approach from gaearon/react-hot-loader#304.