Skip to content

Commit

Permalink
fix: 🐛 removed offline-first paradigm
Browse files Browse the repository at this point in the history
Since cra v4 its opt-in and this project won't support it out-of-the-box
  • Loading branch information
Can-Sahin committed Jan 18, 2021
1 parent 386de98 commit a27ceca
Show file tree
Hide file tree
Showing 10 changed files with 3 additions and 350 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ But wait... there's more!
- _Stay fast_: Profile your app's performance from the comfort of your command
line!

<sub><i>Keywords: Create React App, React Boilerplate, Custom Template, Typescript, React.js, Redux, Hot Reloading, ESNext, Babel, react-router, Offline First, ServiceWorker, `styled-components`, redux-saga, FontFaceObserver</i></sub>
<sub><i>Keywords: Create React App, React Boilerplate, Custom Template, Typescript, React.js, Redux, Hot Reloading, ESNext, Babel, react-router, `styled-components`, redux-saga, FontFaceObserver</i></sub>

## Contributors

Expand Down
6 changes: 0 additions & 6 deletions internals/startingTemplate/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import 'react-app-polyfill/stable';
import * as React from 'react';
import * as ReactDOM from 'react-dom';
import { Provider } from 'react-redux';
import * as serviceWorker from 'serviceWorker';

// Use consistent styling
import 'sanitize.css/sanitize.css';
Expand Down Expand Up @@ -46,8 +45,3 @@ if (module.hot) {
// No need to render the App again because i18next works with the hooks
});
}

// If you want your app to work offline and load faster, you can change
// unregister() to register() below. Note this comes with some pitfalls.
// Learn more about service workers: https://bit.ly/CRA-PWA
serviceWorker.unregister();
146 changes: 0 additions & 146 deletions internals/startingTemplate/src/serviceWorker.ts

This file was deleted.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,7 @@
"!src/**/*/messages.ts",
"!src/reportWebVitals.ts",
"!src/**/*/types.ts",
"!src/index.tsx",
"!src/serviceWorker.ts"
"!src/index.tsx"
],
"coverageThreshold": {
"global": {
Expand Down
11 changes: 0 additions & 11 deletions src/app/containers/HomePage/Features.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import { ReactComponent as RouteIcon } from './assets/route.svg';
import { ReactComponent as SEOIcon } from './assets/seo.svg';
import { ReactComponent as InstantFeedbackIcon } from './assets/instant-feedback.svg';
import { ReactComponent as ScaffoldingIcon } from './assets/scaffolding.svg';
import { ReactComponent as OfflineFirstIcon } from './assets/offline-first.svg';
import { ReactComponent as CodeAnalysisIcon } from './assets/code-analysis.svg';
import { useTranslation } from 'react-i18next';
import { Link } from 'app/components/Link';
Expand Down Expand Up @@ -144,16 +143,6 @@ export function Features() {
</P>
</Content>
</Feature>
<Feature>
<OfflineFirstIcon className="feature-icon" />
<Content>
<SubTitle>Offline-First</SubTitle>
<P>
The next frontier in performant web apps: availability without a
network connection from the instant your users load the app.
</P>
</Content>
</Feature>
<Feature>
<CodeAnalysisIcon className="feature-icon" />
<Content>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -177,19 +177,6 @@ exports[`<Features /> should render with de translations 1`] = `
</P>
</Features__Content>
</Features__Feature>
<Features__Feature>
<ForwardRef(SvgOfflineFirst)
className="feature-icon"
/>
<Features__Content>
<SubTitle>
Offline-First
</SubTitle>
<P>
The next frontier in performant web apps: availability without a network connection from the instant your users load the app.
</P>
</Features__Content>
</Features__Feature>
<Features__Feature>
<ForwardRef(SvgCodeAnalysis)
className="feature-icon"
Expand Down Expand Up @@ -384,19 +371,6 @@ exports[`<Features /> should render with en translations 1`] = `
</P>
</Features__Content>
</Features__Feature>
<Features__Feature>
<ForwardRef(SvgOfflineFirst)
className="feature-icon"
/>
<Features__Content>
<SubTitle>
Offline-First
</SubTitle>
<P>
The next frontier in performant web apps: availability without a network connection from the instant your users load the app.
</P>
</Features__Content>
</Features__Feature>
<Features__Feature>
<ForwardRef(SvgCodeAnalysis)
className="feature-icon"
Expand Down
4 changes: 0 additions & 4 deletions src/app/containers/HomePage/assets/offline-first.svg

This file was deleted.

6 changes: 0 additions & 6 deletions src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import * as React from 'react';
import * as ReactDOM from 'react-dom';
import { Provider } from 'react-redux';
import FontFaceObserver from 'fontfaceobserver';
import * as serviceWorker from 'serviceWorker';

// Use consistent styling
import 'sanitize.css/sanitize.css';
Expand Down Expand Up @@ -59,8 +58,3 @@ if (module.hot) {
// No need to render the App again because i18next works with the hooks
});
}

// If you want your app to work offline and load faster, you can change
// unregister() to register() below. Note this comes with some pitfalls.
// Learn more about service workers: https://bit.ly/CRA-PWA
serviceWorker.unregister();
Loading

0 comments on commit a27ceca

Please sign in to comment.