Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations aren't working properly if Loadable.ts isn't use. #103

Closed
safranx opened this issue Dec 31, 2020 · 2 comments
Closed

Translations aren't working properly if Loadable.ts isn't use. #103

safranx opened this issue Dec 31, 2020 · 2 comments

Comments

@safranx
Copy link

safranx commented Dec 31, 2020

Before opening a new issue, please take a moment to review our community guidelines to make the contribution process easy and effective for everyone involved.

Description

This issue follow the issue #102.

Translations aren't working properly if the component or container isn't import with his "optional" Loadable.ts (async load).

@hyperremix
Copy link

I'm facing the same issue. For some reason the translations object comes back as an empty object unless you're lazy loading your component or container.

Can-Sahin added a commit that referenced this issue Jan 18, 2021
Message objects must be loaded dynamically,
since the translation objects are initialised during the mount

fixes #103
@Can-Sahin
Copy link
Member

Ops. My bad. You can fix easily.

Just look at the changes in the file src/app/containers/LanguageSwitch/messages.ts on 02d9a1d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants