Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --dry-run flag to release tooling #563

Closed
mtscout6 opened this issue Apr 24, 2015 · 5 comments · Fixed by #565
Closed

Add --dry-run flag to release tooling #563

mtscout6 opened this issue Apr 24, 2015 · 5 comments · Fixed by #565
Assignees

Comments

@mtscout6
Copy link
Member

The current release tooling is currently sketchy to test, especially since it's usage is very public in nature. Adding a --dry-run flag that simply skips any steps that tag, push, commit, or publish. An additional thing to skip would be the final cleanup that removes temporary folders. This way you can verify that the contents of these temporary folders are as you expect.

Original conversation for this from #547

@dozoisch
Copy link
Member

I would let the tagging happen so you can check that the tags are okay. Would be nice if it outputted to stdout all the missing 'cleanup' commands. Like

  • To remove the tags do git tag -d TAGNAME
  • clean up x,y,z temps folders once done rm -rf foldernames
  • etc.

@mtscout6
Copy link
Member Author

What if instead for the operations that we skip we send a console.log call with grey coloring. It's easy to forget to remove those tags.

@mtscout6
Copy link
Member Author

I'm not too worried about the temp folders hanging around, they are already in the .gitignore, and we remove those folders before we do anything with them.

@dozoisch
Copy link
Member

Actually, if we can send all the commands in grey fo the dry run that be perfect (maybe add a verbose option for that?)

@mtscout6
Copy link
Member Author

I can do that as well

mtscout6 added a commit that referenced this issue Apr 24, 2015
Add `--dry-run` and `--verbose` options to release process to facilitate
some means to test the release process. Also fixes a few bugs found in
the existing process along the way.

Closes #563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants