-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use RCW disabled to avoid unnecessary unmount #2241
Conversation
can we kill this version eye thing?? |
I deleted the web hook... let's see if that works. |
This change broke preact compatibility. Not sure why but 0.30.3 DropdownMenu works in preact while 0.30.4 does not. |
0.30.4 is broken; it was untagged and the current release is 0.30.5. |
@saxicek just curious if the latest version works with Preact? |
@ngduc Tested with react-bootstrap@0.30.7, preact@7.1.0 and preact-compat@3.13.0 and it still does not work. Also tried with 0.30.3 which does not work either so now I am not sure what causes the issue. My test is described at preactjs/preact-compat#146 if you want to replicate and dive deeper. |
this definitely works with React, because we have behavior depending on the components saying mounted. Not sure about Preact, but there isn't much we can do on that front. |
Yes, I can confirm it works with React. I was only discussing preact-compat compatibility where dropdown menu does not work. |
sure :) just wanted to add that i don't think we had a regression somewhere, so soundly in Preacts compat layer |
No description provided.