Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use RCW disabled to avoid unnecessary unmount #2241

Merged
merged 1 commit into from
Sep 30, 2016
Merged

Conversation

jquense
Copy link
Member

@jquense jquense commented Sep 30, 2016

No description provided.

@jquense
Copy link
Member Author

jquense commented Sep 30, 2016

can we kill this version eye thing??

@jquense jquense merged commit ddc7b45 into master Sep 30, 2016
@jquense jquense deleted the menu-root-close branch September 30, 2016 17:58
@taion
Copy link
Member

taion commented Sep 30, 2016

I deleted the web hook... let's see if that works.

@saxicek
Copy link

saxicek commented Oct 5, 2016

This change broke preact compatibility. Not sure why but 0.30.3 DropdownMenu works in preact while 0.30.4 does not.

@taion
Copy link
Member

taion commented Oct 5, 2016

0.30.4 is broken; it was untagged and the current release is 0.30.5.

@ngduc
Copy link

ngduc commented Jan 26, 2017

@saxicek just curious if the latest version works with Preact?

@saxicek
Copy link

saxicek commented Jan 31, 2017

@ngduc Tested with react-bootstrap@0.30.7, preact@7.1.0 and preact-compat@3.13.0 and it still does not work. Also tried with 0.30.3 which does not work either so now I am not sure what causes the issue.

My test is described at preactjs/preact-compat#146 if you want to replicate and dive deeper.

@jquense
Copy link
Member Author

jquense commented Jan 31, 2017

this definitely works with React, because we have behavior depending on the components saying mounted. Not sure about Preact, but there isn't much we can do on that front.

@saxicek
Copy link

saxicek commented Jan 31, 2017

Yes, I can confirm it works with React. I was only discussing preact-compat compatibility where dropdown menu does not work.

@jquense
Copy link
Member Author

jquense commented Jan 31, 2017

sure :) just wanted to add that i don't think we had a regression somewhere, so soundly in Preacts compat layer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants