Update to webpack4 and simplify build tooling #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taion
reviewed
Mar 30, 2018
| * compiled common js files to ./lib. | ||
| */ | ||
| const buildLib = step('commonjs modules', libRoot, () => | ||
| execa.shell(`npx babel ${srcRoot} --out-dir ${libRoot} --env-name "lib"`, { |
There was a problem hiding this comment.
why npx instead of just using a dev dep?
There was a problem hiding this comment.
it is a dev dep, but this saves me from having to do node_modules/.bin/node
taion
previously approved these changes
Mar 30, 2018
taion
previously approved these changes
Apr 12, 2018
Merged
This was referenced Oct 10, 2018
This was referenced Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slowly trimming it all down to nothing