Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peerDependency invalid on npm2 #137

Closed
bdefore opened this issue Dec 10, 2015 · 2 comments
Closed

peerDependency invalid on npm2 #137

bdefore opened this issue Dec 10, 2015 · 2 comments

Comments

@bdefore
Copy link

bdefore commented Dec 10, 2015

react-router is now version 1.0.2 and your peerDependency of react-router@>=1.0.0-rc3 is invalid with npm 2 due to how it handles pre-release versioning: npm/npm#8854

I suggest updating it to react-router@>=1.0.0
bdefore added a commit to bdefore/universal-redux that referenced this issue Dec 10, 2015
@bdefore
react-router-bootstrap peerDependency is invalid on npm2 react-bootst…
7e043d9 
…rap/react-router-bootstrap#137
@taion
Copy link
Member

taion commented Dec 10, 2015

You have it inverted. The issue there is that e.g. 1.1.0-rc won't satisfy >= 1.0.0. However 1.0.2 satisfies >= 1.0.0-rc3 just fine. I'd accept a PR to fix it but I'm not cutting a new release for this.

@taion taion closed this as completed Dec 10, 2015
@bdefore
Copy link
Author

bdefore commented Dec 10, 2015

Ah ok, thanks @taion

bdefore added a commit to bdefore/universal-redux that referenced this issue Dec 11, 2015
@bdefore
react-router-bootstrap peerDependency is invalid on npm2 react-bootst…
a8379d2 
…rap/react-router-bootstrap#137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdefore @taion