feat: support items & add deprecated warning #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
==========================================
+ Coverage 98.85% 99.12% +0.27%
==========================================
Files 4 5 +1
Lines 87 114 +27
Branches 33 40 +7
==========================================
+ Hits 86 113 +27
Misses 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Wxh16144
force-pushed
the
wuxh/perf-items
branch
from
155f29f
to
010d309
Compare
This reverts commit fe8951f. # Conflicts: # src/Collapse.tsx
|
覆盖率掉了，看看？ |
zombieJ
reviewed
Mar 29, 2023
属性是透传的，所以忽略了，可以考虑补一补 |
|
TODOs:
|
This reverts commit 1143d31.
zombieJ
reviewed
Mar 29, 2023
src/Collapse.tsx
Outdated
| @@ -114,7 +121,62 @@ const Collapse = React.forwardRef<HTMLDivElement, CollapseProps>((props, ref) => | |||
| return React.cloneElement(child, childProps); | |||
| }; | |||
|
|
|||
| const children = toArray(rawChildren).map(getNewChild); | |||
| // eslint-disable-next-line @typescript-eslint/no-shadow | |||
| const convertItemsToNodes = (items: ItemType[]) => | |||
There was a problem hiding this comment.
这个抽成一个 hooks：
const childNodes = useItems(items, rawChildren);
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
zombieJ
reviewed
Mar 29, 2023
This reverts commit 59a9d5f.
Closed
20 tasks
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.