-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add modalRender #195
Conversation
please add a test case for the feature |
I my memory, antd side always use |
#119 能满足需求么? |
可以满足,但是通过wrapRenderer,可以将react-draggable解耦出去,这样可以方便的扩展操作modal的body |
yes , I should rename it to |
yes, I think overlay is better. |
Thank you very much for your guidance. rename it to |
@afc163 |
@afc163 那个..... 可以帮我检查一下PR 吗?, 如果不忙的话。 |
是否可以直接 |
好的,已经调整了。 |
@07akioni 已经调整为 |
@zombieJ 能帮我看一下? 我已经调整了。 |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/dialog/gdwp403i2 |
好了,已经调整了。非常抱歉,之前对rebase命令使用的少 (/ω\)。 |
test: 添加的测试用例 fix
不用每次都 force push 的,就 rebase 或者 merge 后 比较好,其他时候可以保留 commit 信息 |
好的,已经调整,感谢指导 ~ |
example 里加一个拖拽的例子吧~ |
好的, 已经补充例子了 。 |
antd 的 feature 分支也需要更新一下 @jhoneybee |
好的。 马上 |
🤔 这个变动的性质是?
🔗 相关 Issue
ant-design/ant-design#16613
ant-design/ant-design#13230
ant-design/ant-design#4617
ant-design/ant-design#374
💡 需求背景和解决方案
添加Modal组件框的body可自定义。这样可以方便的重写body, 来进行自定义拖拽,或者最大化,最小化等功能
📝 更新日志怎么写?
☑️ 请求合并前的自查清单