Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use watch trigger re-render twice in React 18 #612

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 11, 2023

@vercel
Copy link

vercel bot commented Aug 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
field-form ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2023 7:57am

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #612 (8fb9777) into master (188e23c) will decrease coverage by 0.23%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 8fb9777 differs from pull request most recent head 666dd95. Consider uploading reports for the commit 666dd95 to get more accurate results

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
- Coverage   99.73%   99.50%   -0.23%     
==========================================
  Files          15       18       +3     
  Lines        1142     1220      +78     
  Branches      261      295      +34     
==========================================
+ Hits         1139     1214      +75     
- Misses          3        6       +3     
Files Changed Coverage Δ
src/index.tsx 100.00% <ø> (ø)
tests/common/InfoField.tsx 100.00% <ø> (ø)
src/useWatch.ts 97.82% <100.00%> (+0.04%) ⬆️
tests/common/index.ts 97.82% <100.00%> (ø)
tests/common/timeout.ts 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ zombieJ merged commit e918484 into master Aug 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-useWatch branch August 11, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant