Fix replaceMessage function to handle escaped variables #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the `replaceMessage` function in `src/utils/validateUtil.ts` to handle escaped variables and add related test cases.
* **replaceMessage function**:
- Update the `replaceMessage` function to skip conversion when `\${xxx}` is passed and convert `${xxx}` correctly.
- Check for the presence of `\${xxx}` and skip conversion in such cases.
- Ensure the function correctly converts `${xxx}` to the corresponding value from the `kv` object.
* **validate.test.tsx**:
- Add test cases to verify the correct handling of `\${xxx}` and `${xxx}`.
- Ensure the test cases cover both scenarios: skipping conversion and converting correctly.
- Add a new test case to handle escaped and unescaped variables correctly.
---
For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/react-component/field-form?shareId=XXXX-XXXX-XXXX-XXXX).
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #716 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 18 18
Lines 1253 1255 +2
Branches 308 294 -14
=======================================
+ Hits 1246 1248 +2
Misses 7 7 ☔ View full report in Codecov by Sentry. |
|
resolved: ant-design/ant-design#50410 |
Wxh16144
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the
replaceMessagefunction insrc/utils/validateUtil.tsto handle escaped variables and add related test cases.replaceMessage function:
replaceMessagefunction to skip conversion when\${xxx}is passed and convert${xxx}correctly.\${xxx}and skip conversion in such cases.${xxx}to the corresponding value from thekvobject.validate.test.tsx:
\${xxx}and${xxx}.For more details, open the Copilot Workspace session.