fix: ensure placeholder is hidden #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/image/deimaqlge |
shaodahong
reviewed
Dec 4, 2020
| @@ -150,7 +147,7 @@ const ImageInternal: CompoundedComponent<ImageProps> = ({ | |||
|
|
|||
| React.useEffect(() => { | |||
| if (isCustomPlaceholder) { | |||
There was a problem hiding this comment.
我看最新的代码已经重构了 这个应该可以 close 了
u3u
added a commit
to u3u/image
that referenced
this pull request
Mar 17, 2021
shaodahong
pushed a commit
that referenced
this pull request
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
抱歉 上次修的还有点小问题
useEffect可能会在getImgRef后执行 😢