fix: change event should provider correct selection data #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 97.34% 97.38% +0.04%
==========================================
Files 5 5
Lines 188 191 +3
Branches 69 69
==========================================
+ Hits 183 186 +3
Misses 5 5 ☔ View full report in Codecov by Sentry. |
|
ant-design/ant-design#46999 也能一起解决么？ |
BatuhanW
reviewed
Mar 11, 2024
|
|
||
| // Fill data | ||
| currentTarget.value = value; | ||
| currentTarget.selectionStart = target.selectionStart; |
There was a problem hiding this comment.
This line causes error for Input component when it's type is email.
<Input type="email />
InvalidStateError: Failed to set the 'selectionStart' property on 'HTMLInputElement': The input element's type ('email') does not support selection.
The problem still persists, I am testing with the latest versions but the problem persists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ant-design/ant-design#47779