chore: fix aria-* attirbutes #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesmeck
reviewed
Apr 27, 2018
src/MenuItem.jsx
Outdated
| 'aria-disabled': props.disabled, | ||
| ...props.attribute, |
There was a problem hiding this comment.
这个 prop.attribute 好像文档里也没写，不知道哪里用的
There was a problem hiding this comment.
我加一下吧，感觉只有在rc-select里有用，而且确实名字也挺含糊的。。
There was a problem hiding this comment.
其实感觉也是没什么用？因为之前是不能通过 props 给 li 传 props，但是 #135 就不需要这个属性了？
There was a problem hiding this comment.
我看了一下，现在readme.md里Menu.Item的props跟实际上的差很多，这个attribute又感觉优点随机，我加到PropTypes的声明里了
yesmeck
reviewed
Apr 27, 2018
src/MenuItem.jsx
Outdated
| role: 'option', | ||
| 'aria-selected': props.isSelected, | ||
| } | ||
| } else if (attrs.role === 'null') { |
picodoth
commented
Apr 27, 2018
| @@ -316,8 +316,8 @@ export class SubPopupMenu extends React.Component { | |||
| ); | |||
| const domProps = { | |||
| className, | |||
| role: 'menu', | |||
| 'aria-activedescendant': '', | |||
There was a problem hiding this comment.
参考： dequelabs/axe-core#179
aria-activedescendant空字符串非法
picodoth
commented
Apr 27, 2018
| @@ -181,11 +195,11 @@ export class MenuItem extends React.Component { | |||
| } | |||
| } | |||
|
|
|||
| MenuItem.isMenuItem = true; | |||
|
这个也合掉？ |
|
看了一下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ant-design/ant-design#10095
The idea is to fix the area-* attributes issue and avoid any breaking changes
before:
after:
