fix: Menu[onClick] should not be triggered by propagated onClick event #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
修复：点击菜单项后，Menu[onClick] 被触发两次，第一次的参数与 README.md 的一致，第二次的参数为 React 的 event 对象。 |
benjycui
commented
May 5, 2018
| @@ -77,7 +77,7 @@ const nestSubMenu = (<SubMenu title={<span>offset sub menu 2</span>} key="4" pop | |||
| function onOpenChange(value) { | |||
| console.log('onOpenChange', value); | |||
| } | |||
| const commonMenu = (<Menu onSelect={handleSelect} onOpenChange={onOpenChange}> | |||
| const commonMenu = (<Menu onClick={handleClick} onOpenChange={onOpenChange}> | |||
benjycui
commented
May 5, 2018
| }; | ||
| } | ||
| // In case that onClick/onMouseLeave/onMouseEnter is passed down from owner | ||
| const mouseEvent = { |
There was a problem hiding this comment.
onClick 会被透传下来，所以 disabled 时需要显式设置为空。
|
语雀这边先锁版本吧，感觉这个点击行为需要讨论一下。
只能在 SubMenu 里面判断 onClick 的类型解决？ |
1 task
|
Looking |
|
这个 PR 要重新实现下。 |
|
可能有一个合理的fix, 现在出去一下，晚上继续搞 |
|
@benjycui 我试了下，rc-select的单测以及antD单测用这个分支跑都没问题，把这里挂掉的单测清掉我觉得就可以合了。。 |
yesmeck
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.