-
Couldn't load subscription status.
- Fork 117
fix: close notification with Enter key #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 141 144 +3
Branches 30 31 +1
=========================================
+ Hits 141 144 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@zombieJ Can you advise why the close element is an anchor rather than a button? Buttons are to be used for performing an in-page action and anchors/links are for navigating to a new page. Based off this, the close element should certainly be a button. Should that be done in another PR? |
|
This is a historical legacy, and now antd, which relies on rc, no longer supports legacy browsers. It is indeed possible to open a new PR to change it. |
|
|
|
@zombieJ Thanks for merging and releasing this important PR. Will this get updated in antd soon or should we create a PR for that now? |
|
Remove |
fixes #299