Skip to content

Conversation

@MehmetYararVX
Copy link
Contributor

fixes #299

@vercel
Copy link

vercel bot commented Mar 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
notification ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 9, 2023 at 11:51AM (UTC)

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #302 (f6a2423) into master (30782cc) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f6a2423 differs from pull request most recent head 9476372. Consider uploading reports for the commit 9476372 to get more accurate results

@@            Coverage Diff            @@
##            master      #302   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          141       144    +3     
  Branches        30        31    +1     
=========================================
+ Hits           141       144    +3     
Impacted Files Coverage Δ
src/Notice.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mellis481
Copy link

@zombieJ Can you advise why the close element is an anchor rather than a button? Buttons are to be used for performing an in-page action and anchors/links are for navigating to a new page. Based off this, the close element should certainly be a button. Should that be done in another PR?

@zombieJ
Copy link
Member

zombieJ commented Mar 10, 2023

This is a historical legacy, and now antd, which relies on rc, no longer supports legacy browsers. It is indeed possible to open a new PR to change it.

@zombieJ zombieJ merged commit ad50a03 into react-component:master Mar 10, 2023
@zombieJ
Copy link
Member

zombieJ commented Mar 10, 2023

+ rc-notification@5.0.3

@mellis481
Copy link

@zombieJ Thanks for merging and releasing this important PR. Will this get updated in antd soon or should we create a PR for that now?

@yoyo837
Copy link
Member

yoyo837 commented Mar 10, 2023

Remove node_modules and lock file, then reinstall it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to close notification using the Enter key

4 participants