Skip to content

feat(RangeSelector): add -input-start and -input-end className to differ inputs #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

guoyunhe
Copy link
Contributor

@guoyunhe guoyunhe commented Dec 30, 2024

在单元测试和端到端测试中,我们经常需要定位 input 元素。而目前 picker 的两个 input 的 className 是完全相同的,定位起来多有不便。因此,我给两个 input 分别增加了不同的类名 rc-picker-input-startrc-picker-input-end,这样定位起来就更加方便了。

Summary by CodeRabbit

  • 新功能

    • 为输入组件增加了自定义 CSS 类名的能力,提高了样式灵活性。
  • 样式

    • 为范围选择器的开始和结束输入框添加了更具体的类名,以便更精细的样式控制。

Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 7:26am

Copy link

coderabbitai bot commented Dec 30, 2024

概述

演练

这个拉取请求包含对 src/PickerInput/Selector/Input.tsxsrc/PickerInput/Selector/RangeSelector.tsx 的修改。在 Input 组件中,添加了一个新的 className 属性,增强了样式的灵活性。在 RangeSelector 组件中,为输入组件添加了更具体的类名,以改善样式定制。

变更

文件 变更摘要
src/PickerInput/Selector/Input.tsx 添加 className 属性,允许传递额外的 CSS 类
src/PickerInput/Selector/RangeSelector.tsx 添加更具体的输入类名

序列图

无需生成序列图,因为变更主要是样式和轻微的代码重构。

可能相关的 PRs

  • fix: arrow position retry #909: 该 PR 涉及向 Input 组件添加 className 属性,与本 PR 中对 RangeSelector 的修改相关,均涉及对 Input 组件属性的样式更新。

建议审核者

  • zombieJ

诗歌

🐰 代码兔子轻轻跳,
类名添加更优雅,
样式灵活如彩虹,
代码之路永无疆!

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

Progress: resolved 1, reused 0, downloaded 0, added 0
 WARN  deprecated eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.
Progress: resolved 8, reused 0, downloaded 5, added 0
 WARN  GET http://10.0.0.28:4873/eslint-plugin-react-hooks error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/eslint-plugin-unicorn/-/eslint-plugin-unicorn-55.0.0.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/eslint/-/eslint-8.57.1.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/typescript/-/typescript-5.7.3.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
Progress: resolved 8, reused 0, downloaded 6, added 0
Progress: resolved 49, reused 0, downloaded 40, added 0
Progress: resolved 78, reused 0, downloaded 68, added 0
Progress: resolved 82, reused 0, downloaded 70, added 0
 WARN  GET http://10.0.0.28:4873/eslint/-/eslint-8.57.1.tgz error (ERR_PNPM_FETCH_504). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/@eslint/js/-/js-8.57.1.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/natural-compare error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/@eslint-community%2Feslint-utils error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/@humanwhocodes%2Fmodule-importer error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/jsesc/-/jsesc-3.1.0.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/pluralize/-/pluralize-8.0.0.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/strip-indent error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/core-js-compat error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/comlink error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/rc-tabs/-/rc-tabs-12.15.0.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/nprogress error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/html2sketch error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/@types%2Fmdast error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/@umijs/core/-/core-4.4.5.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
Progress: resolved 82, reused 0, downloaded 71, added 0
Progress: resolved 90, reused 0, downloaded 77, added 0
Progress: resolved 92, reused 0, downloaded 78, added 0
Progress: resolved 93, reused 0, downloaded 79, added 0
 WARN  GET http://10.0.0.28:4873/@umijs/utils/-/utils-4.4.5.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/html-to-text error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/@humanwhocodes%2Fmodule-importer error (504). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/prism-themes error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/hast-util-raw error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/strip-indent error (504). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/remark-rehype/-/remark-rehype-10.1.0.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/github-slugger/-/github-slugger-1.5.0.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/comlink error (504). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/dumi-afx-deps/-/dumi-afx-deps-1.0.0-alpha.20.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/rc-tabs/-/rc-tabs-12.15.0.tgz error (ERR_PNPM_FETCH_504). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/@stackblitz%2Fsdk error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/nprogress/-/nprogress-0.2.0.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/html2sketch/-/html2sketch-1.0.2.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/lodash.throttle error (504). Will retry in 10 seconds. 2 retries left.
Progress: resolved 94, reused 0, downloaded 79, added 0
Progress: resolved 94, reused 0, downloaded 80, added 0
Progress: resolved 94, reused 0, downloaded 81, added 0
 WARN  GET http://10.0.0.28:4873/@umijs/utils/-/utils-4.4.5.tgz error (ERR_PNPM_FETCH_504). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/hosted-git-info/-/hosted-git-info-6.1.3.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/prism-themes error (504). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/hast-util-raw error (504). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/remark-rehype/-/remark-rehype-10.1.0.tgz error (ERR_PNPM_FETCH_504). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/github-slugger/-/github-slugger-1.5.0.tgz error (ERR_PNPM_FETCH_504). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/dumi-afx-deps/-/dumi-afx-deps-1.0.0-alpha.20.tgz error (ERR_PNPM_FETCH_504). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/@stackblitz%2Fsdk error (504). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/nprogress/-/nprogress-0.2.0.tgz error (ERR_PNPM_FETCH_504). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/html2sketch/-/html2sketch-1.0.2.tgz error (ERR_PNPM_FETCH_504). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/lodash.throttle error (504). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/@makotot%2Fghostui error (504). Will retry in 10 seconds. 2 retries left.
Progress: resolved 95, reused 0, downloaded 81, added 0
Progress: resolved 99, reused 0, downloaded 85, added 0
 WARN  GET http://10.0.0.28:4873/hosted-git-info/-/hosted-git-info-6.1.3.tgz error (ERR_PNPM_FETCH_504). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/enhanced-resolve error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/remark-directive error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/unist-util-visit error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/v8-compile-cache error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/comlink/-/comlink-4.4.2.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
Progress: resolved 100, reused 0, downloaded 85, added 0
Progress: resolved 108, reused 0, downloaded 89, added 0
Progress: resolved 109, reused 0, downloaded 91, added 0
Progress: resolved 110, reused 0, downloaded 91, added 0
Progress: resolved 110, reused 0, downloaded 92, added 0
 WARN  GET http://10.0.0.28:4873/copy-to-clipboard error (504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/prism-themes/-/prism-themes-1.9.0.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/hast-util-raw/-/hast-util-raw-8.0.0.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/remark-directive error (504). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/dumi-assets-types/-/dumi-assets-types-2.4.14.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/estree-util-to-js/-/estree-util-to-js-1.2.0.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/unist-util-visit/-/unist-util-visit-4.1.2.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/v8-compile-cache/-/v8-compile-cache-2.3.0.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/estree-util-visit/-/estree-util-visit-1.2.1.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/file-system-cache error (504). Will retry in 10 seconds. 2 retries left.
Progress: resolved 114, reused 0, downloaded 94, added 0
 WARN  GET http://10.0.0.28:4873/remark-frontmatter error (504). Will retry in 10 seconds. 2 retries left.
Progress: resolved 116, reused 0, downloaded 94, added 0
 WARN  GET http://10.0.0.28:4873/animated-scroll-to/-/animated-scroll-to-2.3.2.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
Progress: resolved 116, reused 0, downloaded 95, added 0
Progress: resolved 121, reused 0, downloaded 101, added 0
Progress: resolved 122, reused 0, downloaded 101, added 0
Progress: resolved 123, reused 0, downloaded 101, added 0
Progress: resolved 125, reused 0, downloaded 103, added 0
Progress: resolved 132, reused 0, downloaded 111, added 0
Progress: resolved 137, reused 0, downloaded 113, added 0
Progress: resolved 138, reused 0, downloaded 115, added 0
 WARN  GET http://10.0.0.28:4873/hast-util-to-estree/-/hast-util-to-estree-2.3.3.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/prism-react-renderer/-/prism-react-renderer-1.3.5.tgz error (ERR_PNPM_FETCH_504). Will retry in 10 seconds. 2 retries left.
Progress: resolved 138, reused 0, downloaded 116, added 0
Progress: resolved 174, reused 0, downloaded 154, added 0
Progress: resolved 179, reused 0, downloaded 159, added 0
Progress: resolved 187, reused 0, downloaded 168, added 0
Progress: resolved 188, reused 0, downloaded 168, added 0
Progress: resolved 191, reused 0, downloaded 172, added 0
Progress: resolved 191, reused 0, downloaded 173, added 0
Progress: resolved 198, reused 0, downloaded 179, added 0
Progress: resolved 218, reused 0, downloaded 197, added 0
Progress: resolved 219, reused 0, downloaded 199, added 0
Progress: resolved 222, reused 0, downloaded 202, added 0
Progress: resolved 234, reused 0, downloaded 214, added 0
Progress: resolved 251, reused 0, downloaded 227, added 0
Progress: resolved 267, reused 0, downloaded 244, added 0
Progress: resolved 311, reused 0, downloaded 282, added 0
Progress: resolved 359, reused 0, downloaded 328, added 0
Progress: resolved 392, reused 0, downloaded 362, added 0
Progress: resolved 433, reused 0, downloaded 401, added 0
Progress: resolved 438, reused 0, downloaded 431, added 0
Progress: resolved 440, reused 0, downloaded 435, added 0
Progress: resolved 441, reused 0, downloaded 435, added 0
Progress: resolved 470, reused 0, downloaded 457, added 0
Progress: resolved 493, reused 0, downloaded 476, added 0
Progress: resolved 506, reused 0, downloaded 487, added 0
Progress: resolved 521, reused 0, downloaded 501, added 0
Progress: resolved 539, reused 0, downloaded 517, added 0
Progress: resolved 549, reused 0, downloaded 530, added 0
Progress: resolved 584, reused 0, downloaded 560, added 0
Progress: resolved 608, reused 0, downloaded 578, added 0
Progress: resolved 642, reused 0, downloaded 602, added 0
Progress: resolved 676, reused 0, downloaded 631, added 0
Progress: resolved 713, reused 0, downloaded 652, added 0
Progress: resolved 733, reused 0, downloaded 669, added 0
Progress: resolved 746, reused 0, downloaded 681, added 0
Progress: resolved 786, reused 0, downloaded 716, added 0
Progress: resolved 826, reused 0, downloaded 753, added 0
Progress: resolved 860, reused 0, downloaded 787, added 0
Progress: resolved 892, reused 0, downloaded 820, added 0
Progress: resolved 926, reused 0, downloaded 840, added 0
Progress: resolved 985, reused 0, downloaded 898, added 0
Progress: resolved 1054, reused 0, downloaded 955, added 0
Progress: resolved 1100, reused 0, downloaded 999, added 0
Progress: resolved 1201, reused 0, downloaded 1094, added 0
Progress: resolved 1275, reused 0, downloaded 1158, added 0
Progress: resolved 1420, reused 0, downloaded 1321, added 0
 WARN  13 deprecated subdependencies found: @esbuild-kit/cjs-loader@2.4.4, @esbuild-kit/core-utils@3.3.2, @esbuild-kit/esm-loader@2.6.5, @floating-ui/react-dom-interactions@0.3.1, @humanwhocodes/config-array@0.13.0, @humanwhocodes/object-schema@2.0.3, @stylelint/postcss-css-in-js@0.38.0, glob@7.2.3, inflight@1.0.6, q@1.5.1, rimraf@3.0.2, source-map-resolve@0.6.0, stable@0.1.8
Packages: +1407
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 ERR_PNPM_FETCH_504  GET http://10.0.0.28:4873/@umijs/utils/-/utils-4.4.5.tgz: Gateway Timeout - 504

This error happened while installing the dependencies of dumi@2.4.18
Progress: resolved 1503, reused 0, downloaded 1404, added 0


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7c41096 and a18bc92.

⛔ Files ignored due to path filters (1)
  • tests/__snapshots__/range.spec.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (2)
  • src/PickerInput/Selector/Input.tsx (2 hunks)
  • src/PickerInput/Selector/RangeSelector.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/PickerInput/Selector/RangeSelector.tsx
  • src/PickerInput/Selector/Input.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.79%. Comparing base (a826a25) to head (a18bc92).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #901   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files          64       64           
  Lines        2649     2649           
  Branches      708      735   +27     
=======================================
  Hits         2617     2617           
  Misses         29       29           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ
Copy link
Member

zombieJ commented Feb 27, 2025

我印象里 RangePicker 是支持 id={['#start-input','#end-input']} 的

@zombieJ zombieJ merged commit 5b74195 into react-component:master Feb 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants