-
-
Notifications
You must be signed in to change notification settings - Fork 324
feat(RangeSelector): add -input-start and -input-end className to differ inputs #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
概述演练这个拉取请求包含对 变更
序列图无需生成序列图,因为变更主要是样式和轻微的代码重构。 可能相关的 PRs
建议审核者
诗歌
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
Progress: resolved 1, reused 0, downloaded 0, added 0 This error happened while installing the dependencies of dumi@2.4.18 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #901 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 64 64
Lines 2649 2649
Branches 708 735 +27
=======================================
Hits 2617 2617
Misses 29 29
Partials 3 3 ☔ View full report in Codecov by Sentry. |
7c41096
to
a18bc92
Compare
我印象里 RangePicker 是支持 id={['#start-input','#end-input']} 的 |
在单元测试和端到端测试中,我们经常需要定位 input 元素。而目前 picker 的两个 input 的 className 是完全相同的,定位起来多有不便。因此,我给两个 input 分别增加了不同的类名
rc-picker-input-start
和rc-picker-input-end
,这样定位起来就更加方便了。Summary by CodeRabbit
新功能
样式