Skip to content

Support number value #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2017
Merged

Support number value #229

merged 1 commit into from
Oct 27, 2017

Conversation

yesmeck
Copy link
Member

@yesmeck yesmeck commented Sep 27, 2017

afc163
afc163 reviewed Sep 27, 2017
View reviewed changes
src/util.js Outdated
@@ -56,7 +56,7 @@ export function preventDefaultEvent(e) {
export function findIndexInValueByKey(value, key) {
let index = -1;
for (let i = 0; i < value.length; i++) {
if (value[i].key === key) {
if (String(value[i].key) === String(key)) {
Copy link
Member

@afc163 afc163 Sep 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

<Select defaultValue={1}>
  <Option value="1">xxx</Option>
  <Option value="2">xxx</Option>
</Select>

这种情况也选中了。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哎。。。要是能把依赖 key 的部分去掉就好了。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那这里就不支持 tags 和 combobox 了，感觉意义也不大。

@yesmeck yesmeck force-pushed the option-number-value branch from fbdb50e to 0157d55 Compare September 27, 2017 14:18
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0157d55 on option-number-value into 5eae362 on master.

@afc163 afc163 mentioned this pull request Oct 13, 2017
Closed
@yesmeck yesmeck merged commit a9a8787 into master Oct 27, 2017
@yesmeck yesmeck deleted the option-number-value branch October 27, 2017 03:06
@tangjinzhou tangjinzhou mentioned this pull request Aug 24, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yesmeck @coveralls @afc163