Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add title for tag in multiple mode (#636) #637

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

nekocode
Copy link
Contributor

fix #636

@vercel
Copy link

vercel bot commented Jun 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/9vx4zDGpA5fjDFsZ1jpanjCnzUfx
✅ Preview: https://select-git-fork-nekocode-tag-title-react-component.vercel.app

@nekocode
Copy link
Contributor Author

nekocode commented Jun 21, 2021

顺便提一下,tests/Multiple.test.tsx 里非相关的代码改动是 git pre-commit hook 触发 prettier 导致的。

@nekocode
Copy link
Contributor Author

@afc163 @xrkffgg 能帮忙 Review 一下么?谢谢

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #637 (62b7d1c) into master (318de43) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 62b7d1c differs from pull request most recent head e90a901. Consider uploading reports for the commit e90a901 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #637   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files          20       20           
  Lines         977      980    +3     
  Branches      324      317    -7     
=======================================
+ Hits          969      972    +3     
  Misses          7        7           
  Partials        1        1           
Impacted Files Coverage Δ
src/Selector/MultipleSelector.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 318de43...e90a901. Read the comment docs.

@xrkffgg
Copy link
Member

xrkffgg commented Jun 21, 2021

multiple 模式也可以加上

@nekocode
Copy link
Contributor Author

multiple 模式也可以加上

@xrkffgg 目前改的就是 multiple 和 tags 模式下的。single 模式我看以前已经加上了。

@xrkffgg
Copy link
Member

xrkffgg commented Jun 21, 2021

我看现在的 multiple demo 上没有

@nekocode
Copy link
Contributor Author

我看现在的 multiple demo 上没有

那是因为 demo 里的传的 content 是 [string, number] 数组,而不是单纯的 string | number

@nekocode
Copy link
Contributor Author

demo 上输出的 content @xrkffgg
image

@nekocode
Copy link
Contributor Author

nekocode commented Jun 21, 2021

这里我考虑过要不要处理 node 数组的情况,但是我看 single selector 里没处理这种情况,所以为了统一我也没处理了。

@xrkffgg xrkffgg requested review from zombieJ and afc163 June 21, 2021 12:22
@afc163 afc163 merged commit ad2dda0 into react-component:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] tag 添加默认 title 属性
3 participants