-
-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add title for tag in multiple mode (#636) #637
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/select/9vx4zDGpA5fjDFsZ1jpanjCnzUfx |
顺便提一下, |
Codecov Report
@@ Coverage Diff @@
## master #637 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 20 20
Lines 977 980 +3
Branches 324 317 -7
=======================================
+ Hits 969 972 +3
Misses 7 7
Partials 1 1
Continue to review full report at Codecov.
|
multiple 模式也可以加上 |
@xrkffgg 目前改的就是 multiple 和 tags 模式下的。single 模式我看以前已经加上了。 |
我看现在的 multiple demo 上没有 |
那是因为 demo 里的传的 content 是 [string, number] 数组,而不是单纯的 string | number |
demo 上输出的 content @xrkffgg |
这里我考虑过要不要处理 node 数组的情况,但是我看 single selector 里没处理这种情况,所以为了统一我也没处理了。 |
fix #636