-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-range support #133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a complicated PR, I need time to review it, thanks. |
👍 |
4.0.0 |
Since you bumped a major version, does this have any breaking changes |
Nope... You can consider that I make a mistake... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for more than 2 handles using
<Slider range={<number>} />
.number
is the number of tracks (i.e.,number === nHandles + 1
).Example of
<Slider range={2} value={[25, 50, 65]} />
:Pushable Handles
I also need pushable handles in my webapp...
The
pushable
property can be set totrue
to enable handle-pushing. When it is a number, the number represents the minimum distance between handles when pushing (pushable={true}
is equivalent topushable={1}
).Example of
<Slider range={3} pushable={10} defaultValue={[10, 25, 45, 70]} />
:It also works correctly with any weird combination of
marks
andstep
.Implementation Details
lowerBound
andupperBound
, theSlider
's state was changed to store abounds
array.marks
andstep
. It then tries to push the surrounding handles away from the moving handle until the needed threshold (the value ofpushable
) is satisfied.IMPORTANT
I couldn't manage to run the test suite. I've cloned the original
slider
repository. Executed:But when I go to http://localhost:8005/examples/, I'm missing resources (they are being searched in the wrong place...). It's the same for tests.
I've only run manual tests on my webapp.
I did modify the test suite, and also added some tests for the new multi-range, but someone must run the test suite to ensure everything works...