Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: trackStyle & handleStyle & railStyle #281

Merged
merged 1 commit into from
Jun 9, 2017
Merged

Conversation

paranoidjk
Copy link
Member

@paranoidjk paranoidjk commented Jun 8, 2017

ref #255 (comment)

@silentcloud @benjycui

Take a look at new api propose.

  • The minimumTrackStyle and maximumTrackStyle will be deprecate at rc-slider@9.x. But will remain at this 8.x minor version upgrade, since wait toantd@3.x and antd-mobile@2.x major version is too late.
  • suggest use handleStyle, trackStyle , railStyle to custom style

@silentcloud Let me konw whether this will have influence to tiny-app.

Name Type Default Description
minimumTrackStyle Object please use trackStyle instead. (only used for slider, just for compatibility , will be deprecate at rc-slider@9.x )
maximumTrackStyle Object please use railStyle instead (only used for slider, just for compatibility , will be deprecate at rc-slider@9.x)
handleStyle Array[Object] | Object [{}] The style used for handle. (both for slider(Object) and range(Array of Object), the array will be used for mutli handle follow element order)
trackStyle Array[Object] | Object [{}] The style used for track. (both for slider(Object) and range(Array of Object), the array will be used for mutli track follow element order)
railStyle Object {} The style used for the track base color.

@paranoidjk paranoidjk changed the title refactor: trackStyle & handleStyle & railStyle [WIP] refactor: trackStyle & handleStyle & railStyle Jun 8, 2017
@paranoidjk paranoidjk changed the title [WIP] refactor: trackStyle & handleStyle & railStyle refactor: trackStyle & handleStyle & railStyle Jun 8, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.98% when pulling 02f0a07 on custom-style into 453cb60 on master.

@silentcloud
Copy link
Member

@paranoidjk 没问题,你发了之后,我在 tiny 里按照新 api 改一下即可

@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.98% when pulling 257ab97 on custom-style into 453cb60 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.98% when pulling a50de57 on custom-style into 453cb60 on master.

@benjycui benjycui merged commit 1f92fb7 into master Jun 9, 2017
@benjycui benjycui deleted the custom-style branch June 9, 2017 02:22
@benjycui
Copy link
Member

benjycui commented Jun 9, 2017

@paranoidjk 没问题,你发了之后,我在 tiny 里按照新 api 改一下即可

这个给我练手吧,只改 web?还是说 web 和 native 都要?

@silentcloud
Copy link
Member

@benjycui native 不用改,只用改 web

@paranoidjk
Copy link
Member Author

@benjycui tiny-app is based on antd-mobile components, so you need upgrade antd-mobile to a beta version with rc-slider@8.1.0 first.

@paranoidjk
Copy link
Member Author

@benjycui @silentcloud antd-mobile 改完了 ant-design/ant-design-mobile@a83d0fe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants