Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed types for ariaValueTextFormatter #801

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

TheNumberOne
Copy link
Contributor

Fixes: #726

@vercel
Copy link

vercel bot commented Nov 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/slider/HTszAAhWRTBc5ZZK2nutRzT3nPmf
✅ Preview: https://slider-git-fork-thenumberone-master-react-component.vercel.app

@TheNumberOne TheNumberOne changed the title fix types for: Fixed types for ariaValueTextFormatter Fixed types for ariaValueTextFormatter Nov 13, 2021
@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #801 (d85e28f) into master (4b17b3d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #801   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files          11       11           
  Lines         756      756           
  Branches      199      199           
=======================================
  Hits          669      669           
  Misses         87       87           
Impacted Files Coverage Δ
src/Range.tsx 77.32% <ø> (ø)
src/Slider.tsx 91.83% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b17b3d...d85e28f. Read the comment docs.

@afc163 afc163 merged commit 68e06cf into react-component:master Nov 13, 2021
@fatso83
Copy link

fatso83 commented Nov 17, 2021

@TheNumberOne Since you seem to possess the magic ability to get a PR with type fixes merged, would you have any chance of getting #713 (or any of the other duplicate PRs) fixing the typing of pushable through the merge process? It's been broken for at least 18 months.

@TheNumberOne
Copy link
Contributor Author

@fatso83 I don't possess any magical ability. Anyways, it looks like afc163 noticed your comment and merged it in for you ^-^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type definitions for aria-valuetext formatters
3 participants