Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolved table's unexpected rounded corners #1060

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sunsunmonkey
Copy link

@sunsunmonkey sunsunmonkey commented Dec 10, 2023

Copy link

vercel bot commented Dec 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2023 3:25am

src/Table.tsx Outdated Show resolved Hide resolved
@yoyo837
Copy link
Member

yoyo837 commented Dec 11, 2023

照常加个用例,保险点。

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0b072c) 99.51% compared to head (041669a) 99.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          47       47           
  Lines        4517     4521    +4     
  Branches      571      571           
=======================================
+ Hits         4495     4499    +4     
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc
Copy link
Member

MadCcc commented Dec 11, 2023

默认情况下不添加 class,应该 showHeader={false} 时添加 -without-header

@MadCcc
Copy link
Member

MadCcc commented Dec 11, 2023

另外感觉只要把 border-radius 给 header 就好了,应该不需要额外添加 class?

@sunsunmonkey
Copy link
Author

默认情况下不添加 class,应该 showHeader={false} 时添加 -without-header

他默认是有header吧,所以我的想法就是在showHeader={false}时去掉-header`,至于那个好像header本身就有一个boder-radius,我也不太清楚了,第一次尝试🤓,大佬见谅

@MadCcc
Copy link
Member

MadCcc commented Dec 11, 2023

看下 snapshot,现在是多了一个 -header 的 class

@sunsunmonkey
Copy link
Author

看下 snapshot,现在是多了一个 -header 的 class

是的,因为默认是有那个header然后,他有个圆角的属性在-container里,所以我想分离开来做,就是showheader为false时去掉-header,其他情况保留-header

@MadCcc
Copy link
Member

MadCcc commented Dec 11, 2023

我推荐是直接把圆角样式写在 header 上,table 不带圆角,这样去掉 header 的时候就没有圆角了

@sunsunmonkey
Copy link
Author

我推荐是直接把圆角样式写在 header 上,table 不带圆角,这样去掉 header 的时候就没有圆角了

ok,我再看看

@sunsunmonkey
Copy link
Author

sunsunmonkey commented Dec 11, 2023

我尝试的其他解决方案 #46389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants