Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove rc-util getDOM #1143

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: remove rc-util getDOM #1143

wants to merge 2 commits into from

Conversation

linxianxi
Copy link
Contributor

@linxianxi linxianxi commented Jun 13, 2024 •
edited
Loading

image diff 显示 instanceof 为 false

image image image

@vercel Vercel
Copy link

vercel bot commented Jun 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 7:32am

@linxianxi linxianxi marked this pull request as draft June 13, 2024 02:35
@afc163
Copy link
Member

afc163 commented Jun 13, 2024

先修一下 ci？

@linxianxi linxianxi marked this pull request as ready for review June 13, 2024 07:31
@linxianxi
Copy link
Contributor Author

ci 应该是上一个版本没修

@linxianxi
Copy link
Contributor Author

linxianxi commented Jun 13, 2024 •
edited
Loading

测试了下确实是这个问题，这么改可以修复 image diff。这边的最新的将 getDOM 直接放在 rc-table 里 image diff 确实失败了。 ant-design/ant-design#49080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linxianxi @afc163