Resolve the issue of table header width collapsing and flashing

[Byte2Tech]

Resolve the issue of table header width collapsing and flashing during the initial rendering when setting sticky=true for a table with a large number of columns.

Summary by CodeRabbit

• 功能更新
  • 修改了FixedHolder组件中表格元素的可见性逻辑，现在表格仅在mergedColumnWidth为假时隐藏，提升了可用性。

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
table	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 5, 2024 8:02am

[coderabbitai]

Walkthrough

此次更改涉及FixedHolder组件中表格元素的可见性样式。原有逻辑在noData或mergedColumnWidth为真时将可见性设置为null，从而隐藏表格。更新后的逻辑简化了这一条件，仅检查mergedColumnWidth。因此，表格现在仅在mergedColumnWidth为假时隐藏，而与noData状态无关。这一改动影响了表格的渲染控制流程。

Changes

文件路径	更改摘要
src/FixedHolder/index.tsx	修改表格元素的可见性逻辑，仅根据mergedColumnWidth决定是否隐藏表格。

Poem

在草地上跳跃的小兔子，
看到变化真是开心事。
表格可见性新逻辑，
让我们一起欢呼雀跃！
只看宽度不再迷，
快乐跳跃乐无比！ 🐰✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f7c04ab and 916b8af.

Files selected for processing (1)

• src/FixedHolder/index.tsx (1 hunks)

Additional comments not posted (1)

src/FixedHolder/index.tsx (1)

152-152: 简化表格可见性条件

此更改通过仅检查 mergedColumnWidth 来简化表格的可见性条件。这可能提高渲染性能，因为减少了影响可见性的条件。但是，建议验证此更改对于 noData 为真但 mergedColumnWidth 不为真的场景的影响，以确保不会引入任何意外的可见性问题。

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.70%. Comparing base (a9490ca) to head (916b8af).
Report is 152 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1187      +/-   ##
==========================================
- Coverage   99.49%   97.70%   -1.79%     
==========================================
  Files          36       75      +39     
  Lines         989     7417    +6428     
  Branches      305     1112     +807     
==========================================
+ Hits          984     7247    +6263     
- Misses          5      164     +159     
- Partials        0        6       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.