feat: add measureRowRender prop #1347
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Walkthrough本次变更新增 Table 的 measureRowRender 扩展点并通过上下文传递，调整 FixedHolder 采用 scrollX 控制宽度，VirtualTable 列宽计算加入 minWidth，ColGroup 在无列时不渲染，文档示例新增/扩充相关用例，样式移除表格单元的 word-break，版本号升至 7.52.7，并补充相应测试。 Changes
Sequence Diagram(s)sequenceDiagram
participant App as App
participant Table as Table
participant Ctx as TableContext
participant FH as FixedHolder
participant MR as MeasureRow
App->>Table: render({ measureRowRender, scroll })
Table->>Ctx: provide { measureRowRender, mergedScrollX }
Table->>FH: render({ scrollX: mergedScrollX, ... })
FH->>MR: render()
MR->>Ctx: useContext()
alt measureRowRender provided
MR->>MR: build default <tr class="rc-table-measure-row" tabIndex=-1>
MR-->>App: return measureRowRender(measureRow)
else
MR-->>App: return default measureRow
end
sequenceDiagram
participant Table as Table
participant FH as FixedHolder (Header)
Note over Table,FH: 水平尺寸控制改为 scrollX
Table->>FH: props { scrollX }
FH->>FH: header table style { minWidth: '100%', width: scrollX }
FH-->>Table: header rendered with width constraint
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @afc163, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical bug affecting table column minWidth in virtualized environments, ensuring that columns correctly respect their minimum width constraints. It also introduces a new API for customizing the internal row used for measurement, providing greater flexibility for complex table setups. The changes enhance the robustness and configurability of the table component, particularly for scenarios involving dynamic content and scrolling.
Highlights
- Table Column
minWidthFix: Resolved an issue whereminWidthproperties for table columns were not correctly applied in virtualized tables, ensuring proper column sizing. - New
measureRowRenderProp: Introduced a newmeasureRowRenderprop to the Table component, allowing custom rendering of the internal measure row. This enables advanced use cases like hiding popups within the measure row. - Improved Table Layout and Styling: Adjusted table styling for
scroll.xto better handleminWidthandwidthproperties, and removedword-break: break-wordfrom table cells in the base stylesheet. - Documentation and Test Updates: Added new examples and updated existing ones to demonstrate the
measureRowRenderfunctionality and to test various table scrolling and column alignment scenarios, along with corresponding snapshot updates.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
afc163
changed the title
There was a problem hiding this comment.
Code Review
This pull request introduces a new internal prop measureRowRender to allow wrapping the MeasureRow component. This is a clever solution to fix an issue where minWidth on columns doesn't work with virtualized tables, by allowing a ConfigProvider to control where popups (like filters) are rendered. The changes are well-contained, and the new example and test case are helpful. I have two suggestions: one to prevent a potential memory leak in the new example, and another to address a minor accessibility concern.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## antd-5.x #1347 +/- ##
============================================
+ Coverage 97.75% 97.76% +0.01%
============================================
Files 77 77
Lines 7660 7707 +47
Branches 1162 1167 +5
============================================
+ Hits 7488 7535 +47
Misses 166 166
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ant-design/ant-design#54906
Summary by CodeRabbit