Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

以value查找label时不排除禁用的节点Entity #236

Merged
merged 17 commits into from
Jun 8, 2020

Conversation

yoyo837
Copy link
Member

@yoyo837 yoyo837 commented May 22, 2020

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #236 into master will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #236      +/-   ##
===========================================
+ Coverage   99.61%   100.00%   +0.38%     
===========================================
  Files          11        11              
  Lines         526       525       -1     
  Branches      156       156              
===========================================
+ Hits          524       525       +1     
+ Misses          2         0       -2     
Impacted Files Coverage Δ
src/hooks/useSelectValues.ts 100.00% <ø> (ø)
src/hooks/useKeyValueMapping.ts 100.00% <100.00%> (ø)
src/utils/legacyUtil.tsx 100.00% <100.00%> (+1.58%) ⬆️
src/utils/valueUtil.ts 100.00% <100.00%> (ø)
src/OptionList.tsx 100.00% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2eec3a...f567d87. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented May 30, 2020

需要加一下 test case

@yoyo837
Copy link
Member Author

yoyo837 commented Jun 1, 2020

image

@yoyo837
Copy link
Member Author

yoyo837 commented Jun 1, 2020

我太难了。

@yoyo837 yoyo837 requested a review from zombieJ June 1, 2020 11:22
src/OptionList.tsx Outdated Show resolved Hide resolved
@yoyo837
Copy link
Member Author

yoyo837 commented Jun 5, 2020

CI 怎么不重新run呢

@zombieJ
Copy link
Member

zombieJ commented Jun 7, 2020

rc-tree-select 发了一个大版本,rebase 一下。

src/utils/legacyUtil.tsx Outdated Show resolved Hide resolved
tests/Select.props.spec.js Outdated Show resolved Hide resolved
tests/Select.spec.js Outdated Show resolved Hide resolved
@zombieJ zombieJ merged commit 089ad33 into react-component:master Jun 8, 2020
@yoyo837 yoyo837 deleted the return-disabled-entity branch June 8, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

表单下的树选择组件 , 叶子节点disabled 后, 树组件不显示对应的title
2 participants