-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]: Add "labelInAriaLive"-property for better accessibility #413
Open
juhoValkonen
wants to merge
20
commits into
react-component:master
Choose a base branch
from
juhoValkonen:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+80
−33
Commits on May 24, 2022
-
Aria-live of TreeSelect option was always updated with the value of the option. In some cases there is some sort of ID in the value field (not relevant for user), and the textual representation in label. In those cases, users with screenreaders are confused, as they hear only some ID-numbers instead of option labels. This is a huge problem for accessibility. Solution Allow developer to decide whether to use option label in aria-live area. There is a new prop ´bool labelInAriaLive (default=false)´ , that the developer can use if he/she wishes. This is a huge enabler for improving accessibility. Notes Also testcase was added and documentation was updated in this commit. This commit will not break any existing usage of treeSelect component, as the default for new prop is false. If ´labelInAriaLive´ is false, everything will work as expected.
Juho Valkonen committedMay 24, 2022 Configuration menu - View commit details
-
Copy full SHA for 572d56f - Browse repository at this point
Copy the full SHA 572d56fView commit details -
Aria-live of TreeSelect option was always updated with the value of the option. In some cases there is some sort of ID in the value field (not relevant for user), and the textual representation in label. In those cases, users with screenreaders are confused, as they hear only some ID-numbers instead of option labels. This is a huge problem for accessibility. Solution Allow developer to decide whether to use option label in aria-live area. There is a new prop ´bool labelInAriaLive (default=false)´ , that the developer can use if he/she wishes. This is a huge enabler for improving accessibility. Notes Also testcase was added and documentation was updated in this commit. This commit will not break any existing usage of treeSelect component, as the default for new prop is false. If ´labelInAriaLive´ is false, everything will work as expected.
Juho Valkonen committedMay 24, 2022 Configuration menu - View commit details
-
Copy full SHA for 6fd6b98 - Browse repository at this point
Copy the full SHA 6fd6b98View commit details -
Merge branch 'master' of https://github.com/juhoValkonen/tree-select
Juho Valkonen committedMay 24, 2022 Configuration menu - View commit details
-
Copy full SHA for 92136b5 - Browse repository at this point
Copy the full SHA 92136b5View commit details
Commits on Jul 28, 2022
-
Juho Valkonen committed
Jul 28, 2022 Configuration menu - View commit details
-
Copy full SHA for 59fedd0 - Browse repository at this point
Copy the full SHA 59fedd0View commit details -
Juho Valkonen committed
Jul 28, 2022 Configuration menu - View commit details
-
Copy full SHA for 134af14 - Browse repository at this point
Copy the full SHA 134af14View commit details -
Juho Valkonen committed
Jul 28, 2022 Configuration menu - View commit details
-
Copy full SHA for 8245216 - Browse repository at this point
Copy the full SHA 8245216View commit details -
Juho Valkonen committed
Jul 28, 2022 Configuration menu - View commit details
-
Copy full SHA for 64f2aea - Browse repository at this point
Copy the full SHA 64f2aeaView commit details -
Juho Valkonen committed
Jul 28, 2022 Configuration menu - View commit details
-
Copy full SHA for 0d44404 - Browse repository at this point
Copy the full SHA 0d44404View commit details -
Juho Valkonen committed
Jul 28, 2022 Configuration menu - View commit details
-
Copy full SHA for d68b2ab - Browse repository at this point
Copy the full SHA d68b2abView commit details -
Juho Valkonen committed
Jul 28, 2022 Configuration menu - View commit details
-
Copy full SHA for 8b252f1 - Browse repository at this point
Copy the full SHA 8b252f1View commit details -
Juho Valkonen committed
Jul 28, 2022 Configuration menu - View commit details
-
Copy full SHA for 37c01c5 - Browse repository at this point
Copy the full SHA 37c01c5View commit details -
Juho Valkonen committed
Jul 28, 2022 Configuration menu - View commit details
-
Copy full SHA for 9b6a12c - Browse repository at this point
Copy the full SHA 9b6a12cView commit details -
Juho Valkonen committed
Jul 28, 2022 Configuration menu - View commit details
-
Copy full SHA for bbfbf18 - Browse repository at this point
Copy the full SHA bbfbf18View commit details -
Juho Valkonen committed
Jul 28, 2022 Configuration menu - View commit details
-
Copy full SHA for 56807bf - Browse repository at this point
Copy the full SHA 56807bfView commit details -
Juho Valkonen committed
Jul 28, 2022 Configuration menu - View commit details
-
Copy full SHA for 512b263 - Browse repository at this point
Copy the full SHA 512b263View commit details -
Juho Valkonen committed
Jul 28, 2022 Configuration menu - View commit details
-
Copy full SHA for d23f40d - Browse repository at this point
Copy the full SHA d23f40dView commit details -
Juho Valkonen committed
Jul 28, 2022 Configuration menu - View commit details
-
Copy full SHA for 596a3ca - Browse repository at this point
Copy the full SHA 596a3caView commit details -
Juho Valkonen committed
Jul 28, 2022 Configuration menu - View commit details
-
Copy full SHA for 77c5361 - Browse repository at this point
Copy the full SHA 77c5361View commit details
Commits on Jul 29, 2022
-
Juho Valkonen committed
Jul 29, 2022 Configuration menu - View commit details
-
Copy full SHA for 5b4275e - Browse repository at this point
Copy the full SHA 5b4275eView commit details -
Juho Valkonen committed
Jul 29, 2022 Configuration menu - View commit details
-
Copy full SHA for 82028b3 - Browse repository at this point
Copy the full SHA 82028b3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.