Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Add "labelInAriaLive"-property for better accessibility #413

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Commits on May 24, 2022

  1. Problem

    Aria-live of TreeSelect option was always updated with the value of the option.
    In some cases there is some sort of ID in the value field (not relevant for user),
    and the textual representation in label. In those cases, users
    with screenreaders are confused, as they hear only some ID-numbers instead
    of option labels. This is a huge problem for accessibility.
    Solution
    Allow developer to decide whether to use option label in aria-live area.
    There is a new prop ´bool labelInAriaLive (default=false)´ , that
    the developer can use if he/she wishes. This is a huge enabler for
    improving accessibility.
    Notes
    Also testcase was added and documentation was updated in this commit.
    
    This commit will not break any existing usage of treeSelect component,
    as the default for new prop is false. If ´labelInAriaLive´ is false,
    everything will work as expected.
    Juho Valkonen committed May 24, 2022
    Configuration menu
    Copy the full SHA
    572d56f View commit details
    Browse the repository at this point in the history
  2. Problem

    Aria-live of TreeSelect option was always updated with the value of the option.
    In some cases there is some sort of ID in the value field (not relevant for user),
    and the textual representation in label. In those cases, users
    with screenreaders are confused, as they hear only some ID-numbers instead
    of option labels. This is a huge problem for accessibility.
    
    Solution
    
    Allow developer to decide whether to use option label in aria-live area.
    There is a new prop ´bool labelInAriaLive (default=false)´ , that
    the developer can use if he/she wishes. This is a huge enabler for
    improving accessibility.
    
    Notes
    
    Also testcase was added and documentation was updated in this commit.
    This commit will not break any existing usage of treeSelect component,
    as the default for new prop is false. If ´labelInAriaLive´ is false,
    everything will work as expected.
    Juho Valkonen committed May 24, 2022
    Configuration menu
    Copy the full SHA
    6fd6b98 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    92136b5 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. package metadata

    Juho Valkonen committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    59fedd0 View commit details
    Browse the repository at this point in the history
  2. 5.4.1

    Juho Valkonen committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    134af14 View commit details
    Browse the repository at this point in the history
  3. 5.4.2

    Juho Valkonen committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    8245216 View commit details
    Browse the repository at this point in the history
  4. Package metadata

    Juho Valkonen committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    64f2aea View commit details
    Browse the repository at this point in the history
  5. 5.4.3

    Juho Valkonen committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    0d44404 View commit details
    Browse the repository at this point in the history
  6. 5.4.4

    Juho Valkonen committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    d68b2ab View commit details
    Browse the repository at this point in the history
  7. Updated package name

    Juho Valkonen committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    8b252f1 View commit details
    Browse the repository at this point in the history
  8. 5.4.2

    Juho Valkonen committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    37c01c5 View commit details
    Browse the repository at this point in the history
  9. Updated package name

    Juho Valkonen committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    9b6a12c View commit details
    Browse the repository at this point in the history
  10. 5.4.5

    Juho Valkonen committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    bbfbf18 View commit details
    Browse the repository at this point in the history
  11. 5.4.6

    Juho Valkonen committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    56807bf View commit details
    Browse the repository at this point in the history
  12. Updated package metadata

    Juho Valkonen committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    512b263 View commit details
    Browse the repository at this point in the history
  13. 5.5.0

    Juho Valkonen committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    d23f40d View commit details
    Browse the repository at this point in the history
  14. Updated package metadata

    Juho Valkonen committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    596a3ca View commit details
    Browse the repository at this point in the history
  15. 5.5.1

    Juho Valkonen committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    77c5361 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2022

  1. Bugfix to OptionList.tsx

    Juho Valkonen committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    5b4275e View commit details
    Browse the repository at this point in the history
  2. 5.5.2

    Juho Valkonen committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    82028b3 View commit details
    Browse the repository at this point in the history