Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide popup when select box is disabled #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ram-krishan
Copy link

Why we need this changes?
Answer: When I am going to disabled the dropdown, still user can able to select items from tree list popup. So I just hiding the tree list popup when select box is disabled.

@codecov-io
Copy link

Codecov Report

Merging #85 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   82.44%   82.47%   +0.02%     
==========================================
  Files           7        7              
  Lines         621      622       +1     
  Branches      194      195       +1     
==========================================
+ Hits          512      513       +1     
  Misses        106      106              
  Partials        3        3
Impacted Files Coverage Δ
src/Select.jsx 79.41% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc350c1...502e2bd. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Dec 18, 2019

conflicted

@ram-krishan
Copy link
Author

ram-krishan commented Dec 18, 2019

@afc163, Will fix the conflict. Are you going to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants