-
-
Notifications
You must be signed in to change notification settings - Fork 225
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Only flip if space is enough (#343)
* chore: improve check logic only flip when has more space * test: add test case
- Loading branch information
Showing
3 changed files
with
270 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,190 @@ | ||
| import { act, cleanup, render } from '@testing-library/react'; | ||
| import { spyElementPrototypes } from 'rc-util/lib/test/domHook'; | ||
| import Trigger from '../src'; | ||
|
|
||
| const builtinPlacements = { | ||
| top: { | ||
| points: ['bc', 'tc'], | ||
| overflow: { | ||
| adjustX: true, | ||
| adjustY: true, | ||
| }, | ||
| }, | ||
| bottom: { | ||
| points: ['tc', 'bc'], | ||
| overflow: { | ||
| adjustX: true, | ||
| adjustY: true, | ||
| }, | ||
| }, | ||
| left: { | ||
| points: ['cr', 'cl'], | ||
| overflow: { | ||
| adjustX: true, | ||
| adjustY: true, | ||
| }, | ||
| }, | ||
| right: { | ||
| points: ['cl', 'cr'], | ||
| overflow: { | ||
| adjustX: true, | ||
| adjustY: true, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| describe('Trigger.Align', () => { | ||
| let spanRect = { | ||
| x: 0, | ||
| y: 0, | ||
| width: 1, | ||
| height: 1, | ||
| }; | ||
|
|
||
| beforeAll(() => { | ||
| spyElementPrototypes(HTMLElement, { | ||
| clientWidth: { | ||
| get: () => 100, | ||
| }, | ||
| clientHeight: { | ||
| get: () => 100, | ||
| }, | ||
| }); | ||
|
|
||
| spyElementPrototypes(HTMLDivElement, { | ||
| getBoundingClientRect() { | ||
| return { | ||
| x: 0, | ||
| y: 0, | ||
| width: 100, | ||
| height: 100, | ||
| }; | ||
| }, | ||
| }); | ||
|
|
||
| spyElementPrototypes(HTMLSpanElement, { | ||
| getBoundingClientRect() { | ||
| return spanRect; | ||
| }, | ||
| }); | ||
|
|
||
| spyElementPrototypes(HTMLElement, { | ||
| offsetParent: { | ||
| get: () => document.body, | ||
| }, | ||
| }); | ||
| }); | ||
|
|
||
| beforeEach(() => { | ||
| spanRect = { | ||
| x: 0, | ||
| y: 0, | ||
| width: 1, | ||
| height: 1, | ||
| }; | ||
| jest.useFakeTimers(); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| cleanup(); | ||
| jest.useRealTimers(); | ||
| }); | ||
|
|
||
| describe('not flip if cant', () => { | ||
| const list = [ | ||
| { | ||
| placement: 'right', | ||
| x: 10, | ||
| className: '.rc-trigger-popup-placement-right', | ||
| }, | ||
| { | ||
| placement: 'left', | ||
| x: 90, | ||
| className: '.rc-trigger-popup-placement-left', | ||
| }, | ||
| { | ||
| placement: 'top', | ||
| y: 90, | ||
| className: '.rc-trigger-popup-placement-top', | ||
| }, | ||
| { | ||
| placement: 'bottom', | ||
| y: 10, | ||
| className: '.rc-trigger-popup-placement-bottom', | ||
| }, | ||
| ]; | ||
|
|
||
| list.forEach(({ placement, x = 0, y = 0, className }) => { | ||
| it(placement, async () => { | ||
| spanRect.x = x; | ||
| spanRect.y = y; | ||
|
|
||
| render( | ||
| <Trigger | ||
| popupVisible | ||
| popupPlacement={placement} | ||
| builtinPlacements={builtinPlacements} | ||
| popup={<strong>trigger</strong>} | ||
| > | ||
| <span className="target" /> | ||
| </Trigger>, | ||
| ); | ||
|
|
||
| await act(async () => { | ||
| await Promise.resolve(); | ||
| }); | ||
|
|
||
| expect(document.querySelector(className)).toBeTruthy(); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| describe('flip if can', () => { | ||
| const list = [ | ||
| { | ||
| placement: 'right', | ||
| x: 90, | ||
| className: '.rc-trigger-popup-placement-left', | ||
| }, | ||
| { | ||
| placement: 'left', | ||
| x: 10, | ||
| className: '.rc-trigger-popup-placement-right', | ||
| }, | ||
| { | ||
| placement: 'top', | ||
| y: 10, | ||
| className: '.rc-trigger-popup-placement-bottom', | ||
| }, | ||
| { | ||
| placement: 'bottom', | ||
| y: 90, | ||
| className: '.rc-trigger-popup-placement-top', | ||
| }, | ||
| ]; | ||
|
|
||
| list.forEach(({ placement, x = 0, y = 0, className }) => { | ||
| it(placement, async () => { | ||
| spanRect.x = x; | ||
| spanRect.y = y; | ||
|
|
||
| render( | ||
| <Trigger | ||
| popupVisible | ||
| popupPlacement={placement} | ||
| builtinPlacements={builtinPlacements} | ||
| popup={<strong>trigger</strong>} | ||
| > | ||
| <span className="target" /> | ||
| </Trigger>, | ||
| ); | ||
|
|
||
| await act(async () => { | ||
| await Promise.resolve(); | ||
| }); | ||
|
|
||
| expect(document.querySelector(className)).toBeTruthy(); | ||
| }); | ||
| }); | ||
| }); | ||
| }); |