Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: arrow add className support #366

Merged
merged 9 commits into from
Apr 19, 2023
Merged

feat: arrow add className support #366

merged 9 commits into from
Apr 19, 2023

Conversation

yoyo837
Copy link
Member

@yoyo837 yoyo837 commented Apr 15, 2023

@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #366 (01b18e3) into master (1650d85) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 01b18e3 differs from pull request most recent head 7992af7. Consider uploading reports for the commit 7992af7 to get more accurate results

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   96.01%   96.03%   +0.02%     
==========================================
  Files          12       12              
  Lines         627      631       +4     
  Branches      185      188       +3     
==========================================
+ Hits          602      606       +4     
  Misses         25       25              
Impacted Files Coverage Δ
src/Popup/index.tsx 90.47% <ø> (ø)
src/Popup/Arrow.tsx 100.00% <100.00%> (ø)
src/index.tsx 95.36% <100.00%> (+0.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/index.tsx Outdated Show resolved Hide resolved
src/index.tsx Fixed Show fixed Hide fixed
src/Popup/Arrow.tsx Fixed Show fixed Hide fixed
src/index.tsx Fixed Show fixed Hide fixed
src/index.tsx Fixed Show fixed Hide fixed
@yoyo837 yoyo837 changed the title feat: arrow add arrowClassName support feat: arrow add className support Apr 16, 2023
src/Popup/Arrow.tsx Outdated Show resolved Hide resolved
src/Popup/Arrow.tsx Outdated Show resolved Hide resolved
@yoyo837 yoyo837 force-pushed the add-arrow-className branch from a9cb31e to b4b75aa Compare April 17, 2023 07:47
src/index.tsx Outdated Show resolved Hide resolved
src/index.tsx Outdated Show resolved Hide resolved
src/index.tsx Fixed Show fixed Hide fixed
@zombieJ zombieJ merged commit aeda4c9 into master Apr 19, 2023
@zombieJ zombieJ deleted the add-arrow-className branch April 19, 2023 06:43
@afc163
Copy link
Member

afc163 commented Apr 25, 2023

ci 挂了

@yoyo837
Copy link
Member Author

yoyo837 commented Apr 25, 2023

好像和本PR无关, checkout 到上一个提交也是挂的, 但是这个PR当时CI是通过的. 放了几天合并后在master跑不过了.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants