Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find element in multilevel shadows #471

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Psvensso
Copy link
Contributor

Fixes #470 #463

@zombieJ zombieJ merged commit e6ac87a into react-component:master Aug 9, 2024
7 checks passed
@iahu
Copy link
Contributor

iahu commented Aug 29, 2024

这个改动导致 antd 的 Popover 在 trigger 为 click 时,点击 popup 内的 webComponent 组件直接关闭弹窗。

@Psvensso
Copy link
Contributor Author

@iahu Can not reproduce what you mean, can you give an example?

Stackblitz with two layers of shadow:
https://stackblitz.com/edit/react-zuo2ca?file=demo.tsx

@iahu
Copy link
Contributor

iahu commented Aug 29, 2024

@iahu Can not reproduce what you mean, can you give an example?

Stackblitz with two layers of shadow: https://stackblitz.com/edit/react-zuo2ca?file=demo.tsx

@Psvensso try to pass a custom-element to the content property. here is a online demo.

I have created a PR to fix this issue, but have't write the test case. open to review now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multilevel shadowDoms not working as expected, popup closes on click inside target
3 participants