Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in DateInput. #925

Merged
merged 1 commit into from
Jan 17, 2018
Merged

Fix typo in DateInput. #925

merged 1 commit into from
Jan 17, 2018

Conversation

codejunkienick
Copy link
Contributor

This typo caused the wrong position of fang when using OPEN_UP constant for openDirection.

ljharb
ljharb reviewed Dec 28, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; could we add a regression test that would have caught this?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.524% when pulling a56aabc on codejunkienick:fix-open-direction into f0b6f2f on airbnb:master.

@codejunkienick
Copy link
Contributor Author

codejunkienick commented Dec 28, 2017 •
edited
Loading

@ljharb we can test if an svg element has 'bottom' or 'top' key in styles object.

@ljharb
Copy link
Member

ljharb commented Dec 28, 2017

Hmm, true, testing styles is probably the only way to cover it, and testing styles is generally not a good practice.

@ljharb
Copy link
Member

ljharb commented Dec 28, 2017

Let's get the tests passing, and then we can probably go forward as-is.

majapw
majapw approved these changes Jan 2, 2018
View reviewed changes
Copy link
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops thank you! LGTM after a rebase!

@ljharb If we got happo running on this repo, that would probs catch the issue. :P

@majapw majapw mentioned this pull request Jan 3, 2018
Closed
@majapw
Copy link
Collaborator

majapw commented Jan 3, 2018

Fixes #904

@majapw
Copy link
Collaborator

majapw commented Jan 17, 2018

Will merge this if travis ever feels better 🤒

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.275% when pulling 26b6786 on codejunkienick:fix-open-direction into 32913a2 on airbnb:master.

@majapw majapw merged commit 602ce9a into react-dates:master Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@majapw majapw majapw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codejunkienick @coveralls @ljharb @majapw