make Draggable explicit default export #254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just commenting to show my interest in this PR getting merged. |
How can I help with it? |
STRML
added a commit
that referenced
this pull request
Aug 21, 2017
|
Fixed in afd7721 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was trying to use this package with my TypeScript setup I ran into the issue that
resulted in
Draggable === undefinedas TypeScript expects default exports to be assigned asmodule.exports.default = .... While I could probably changetypings/index.d.tsto match the actual behaviorimport * as Draggable from 'react-draggable'I understand that the import statement above is the desired behavior.This PR changes
index.jsto meet TS' expectation but doesn't remove the currentmodule.exports = ...to avoid breaking compatibility.I am not sure how exactly I could provide a unit-test for this. Any help appreciated.