Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests calcWH and calcXY #1637

Merged
merged 10 commits into from
Jan 6, 2022
Merged

Conversation

imagineLife
Copy link
Contributor

This is to increase code coverage

@STRML
Copy link
Collaborator

STRML commented Jan 4, 2022

Hey, looks like the pre-merge checks are working properly now and you have a few small type errors. I can merge when they're fixed up. Thanks a ton for the contribution!

@github-actions github-actions bot added documentation use this label for changes in documentation infrastructure labels Jan 4, 2022
@imagineLife
Copy link
Contributor Author

Hey @STRML 👋 Thanks for the note here -
In favor of trusting the type-checking, some js error-checking && error-validating test code is now removed from the code.
Also, a --coverage flag is included in the make test script here to begin ensuring code-coverage stays at least at its current threshold 🤞

@STRML STRML merged commit 388b79f into react-grid-layout:master Jan 6, 2022
@STRML
Copy link
Collaborator

STRML commented Jan 6, 2022

Thanks a ton @imagineLife!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation use this label for changes in documentation infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants