Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checking the compactType null value to avoid breaking the layout when overlapping is allowed. #1782

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

jaloveeye
Copy link
Contributor

When allowOverlap is true and compactType is null, the layout is unintentionally transformed like the AS-IS gif.

AS-IS

Adding an exception when compactType is null in compactItem avoids unintended layout transformed.

PR

… overlapping is allowed in compactItem func.
@STRML
Copy link
Collaborator

STRML commented Oct 12, 2022

Shouldn't this also be checking if allowOverlap is true? Otherwise, when it is the default value, no collisions will occur when compactType is null.

@jaloveeye
Copy link
Contributor Author

@STRML
Thank you for your advice.
I was missing out that.
Your advice has been reflected.

@STRML STRML merged commit 33e22c7 into react-grid-layout:master Feb 24, 2023
@STRML
Copy link
Collaborator

STRML commented Feb 24, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants