Allow resolver output type to truly differ #11951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for resolvers to parse to a different type that doesn't have to have the same shape as TFieldValues. This commit contains type-only changes. No runtime changes are introduced.
Test that `useWatch` returns `TFieldValues` values, not `TTransformedValues` ones. Test that `TTransformedValues` are submitted on success and `TFieldValues` on failure.
|
Any progress on this ? |
|
It was ready to go but didn't get merged so it's just a case of fixing the conflicts again. |
|
Hi @jedahu |
|
I will look at it, and see if I can resolve those conflicts. |
|
@jorisre this has never pass the build |
This comment has been minimized.
This comment has been minimized.
bluebill1049
added a commit
that referenced
this pull request
Mar 13, 2025
* Allow resolver output type to truly differ (#11951) * Default TTransformedValues to TFieldValues without constraint This allows for resolvers to parse to a different type that doesn't have to have the same shape as TFieldValues. This commit contains type-only changes. No runtime changes are introduced. * Tests for TTransformedValues change Test that `useWatch` returns `TFieldValues` values, not `TTransformedValues` ones. Test that `TTransformedValues` are submitted on success and `TFieldValues` on failure. * Add type test for useForm inference From: https://github.com/react-hook-form/react-hook-form/pull/11913/files --------- Co-authored-by: Beier (Bill) <bluebill1049@hotmail.com> * feat: add automatic output type inference from resolver functions * fix: resolvers type inference * chore: api extractor * test build * Revert "test build" This reverts commit 16e5661. --------- Co-authored-by: Jeremy Hughes <jedahu@gmail.com> Co-authored-by: Beier (Bill) <bluebill1049@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the
TFieldValuesconstraint fromTTransformedValuesallows for resolvers to parse to different shaped output types.Defaulting
TTransformValuestoTFieldValuesinstead ofundefinedmeans some conditional types can be removed (like those onUseFormHandleSubmit).I have changed the types only. There are no runtime changes in this PR.