Upgrade Valibot and refactor resolver with new util

react-hook-form · Jun 4, 2024 · 3b2e265 · 3b2e265
1 parent 67d778c
commit 3b2e265
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 46 deletions.
diff --git a/package.json b/package.json
@@ -262,7 +262,7 @@
     "superstruct": "^1.0.3",
     "typanion": "^3.14.0",
     "typescript": "^5.1.6",
-    "valibot": "0.31.0-rc.11",
+    "valibot": "0.31.0-rc.12",
     "vest": "^4.6.11",
     "vite": "^4.4.9",
     "vite-tsconfig-paths": "^4.2.0",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/valibot/src/valibot.ts b/valibot/src/valibot.ts
@@ -1,6 +1,6 @@
 import { toNestErrors } from '@hookform/resolvers';
 import { FieldError, appendErrors, FieldValues } from 'react-hook-form';
-import { safeParseAsync } from 'valibot';
+import { getDotPath, safeParseAsync } from 'valibot';
 import type { Resolver } from './types';
 
 export const valibotResolver: Resolver =
@@ -23,47 +23,31 @@ export const valibotResolver: Resolver =
 
       // Iterate over issues to add them to errors object
       for (const issue of result.issues) {
-        if (issue.path) {
-          // Create path string from issue path
-          let path = '';
-          for (const item of issue.path) {
-            if (
-              'key' in item &&
-              (typeof item.key === 'string' || typeof item.key === 'number')
-            ) {
-              if (path) {
-                path += `.${item.key}`;
-              } else {
-                path += item.key;
-              }
-            } else {
-              break;
-            }
-          }
+        // Create dot path from issue
+        const path = getDotPath(issue);
 
-          if (path) {
-            // Add first error of path to errors object
-            if (!errors[path]) {
-              errors[path] = { message: issue.message, type: issue.type };
-            }
+        if (path) {
+          // Add first error of path to errors object
+          if (!errors[path]) {
+            errors[path] = { message: issue.message, type: issue.type };
+          }
 
-            // If configured, add all errors of path to errors object
-            if (validateAllFieldCriteria) {
-              const types = errors[path].types;
-              const messages = types && types[issue.type];
-              errors[path] = appendErrors(
-                path,
-                validateAllFieldCriteria,
-                errors,
-                issue.type,
-                messages
-                  ? ([] as string[]).concat(
-                      messages as string | string[],
-                      issue.message,
-                    )
-                  : issue.message,
-              ) as FieldError;
-            }
+          // If configured, add all errors of path to errors object
+          if (validateAllFieldCriteria) {
+            const types = errors[path].types;
+            const messages = types && types[issue.type];
+            errors[path] = appendErrors(
+              path,
+              validateAllFieldCriteria,
+              errors,
+              issue.type,
+              messages
+                ? ([] as string[]).concat(
+                    messages as string | string[],
+                    issue.message,
+                  )
+                : issue.message,
+            ) as FieldError;
           }
         }
       }