V2 🚀 #108
Merged
V2 🚀 #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: there will be some breaking changes in the next versions
* test: add components test to ensure TypeScript is working as expected Related to #97 * chore: improve zod resolvers types * chore(eslint): remove warnings * test: add severals tests & improve typings * chore: setup compressed-size * test: update describe
|
Size Change: -9.58 kB (-49%) 🎉 Total Size: 9.98 kB
|
|
Can we remove // Todo: to be removed
import set from '../utils/set';
import isKey from '../utils/isKey';
import { FieldValues } from '../types';
export default (data: FieldValues, value: Record<string, any> = {}): any => {
for (const key in data) {
!isKey(key) ? set(value, key, data[key]) : (value[key] = data[key]);
}
return value;
};I think we can export I did a quick test by removed that function |
Yes you can replace this function |
* feat: add Joi sync validation * fix(joi): sync error * test: add validateAllCriteria test * test(joi): update test description
* feat: add Yup sync validation * test(zod): add tests * test(zod): update tests * test(yup): add validateAllCriteria test
BREAKING CHANGE: Require react-hook-form >= 7
* chore: update deps * chore: fix TypeScript error
* test: extract fixtures * fix: zod resolver union error + reduce resolver size
* feat: add error's ref * test: add error's ref + extract fixtures * test: add nested test * refactor: rename toNestObject to toNestError
* test: extract test's fixtures * test: jest fixtures config * perf: reduce superstruct resolver size * feat: add error's ref * test: add error's ref + extract fixtures * test: add nested test * refactor: rename toNestObject to toNestError * refactor: remove duplicate line * chore: update superstruct peer dep
* test: extract test's fixtures * test: jest fixtures config * perf: reduce superstruct resolver size * feat: add error's ref * test: add error's ref + extract fixtures * test: add nested test * refactor: rename toNestObject to toNestError * refactor: remove duplicate line * perf: recude vest resolver bundle size
* perf: reduce Joi resolver's size * perf: reduce Vest resolver's size
|
Hey @jorisre, More of a question, Do we need to include the src folders? cause i didn't include |
|
Hey @bluebill1049 |
|
It's minor don't worry about it @jorisre. I was referring to the |
|
|
bluebill1049
approved these changes
Apr 2, 2021
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolvers V2 🚀
Root branch for V2 work.
Update to react-hook-form v7 - #118
Breaking changes: yes 🟥
Global improvements
Breaking changes: no 🟩
Improve bundle output format: CJS, ESM & UMD - #104
First of all, huge thank to the preact hard work. This PR is heavily inspired of their modules structure.
Breaking changes: no 🟩
Related: #71 & #100
Support sync/async validation
Breaking changes: no 🟩
Related to #88
Resolver get a third optional param. Async mode is set by default.
Before:
After:
Pass down Joi context - #124
Breaking changes: no 🟩
Related to #121
Zod resolver: add union errors + reduce bundle size by ~23% - #126
Breaking changes: no 🟩
Related to #119
Add error's reference - #127
Breaking changes: no 🟩
Related to #77
Reduce resolvers's size
Breaking changes: no 🟩