improve types #12
improve types #12
Conversation
src/superstruct.ts
Outdated
| validateAllFieldCriteria, | ||
| previous, | ||
| type, | ||
| type!, |
There was a problem hiding this comment.
@bluebill1049 type may be undefined.
using ! to ignore type errors, how should I fix this?
There was a problem hiding this comment.
maybe we should omit the type if it can be undefined? your thoughts?
There was a problem hiding this comment.
@bluebill1049 If we omit type, I think you need to fix FieldError type as follows.
export type FieldError = {
- type: string;
+ type?: string;
ref?: Ref;
types?: MultipleFieldErrors;
message?: Message;
isManual?: boolean;
}I think it's better to use an empty string ('') to avoid this fix.
There was a problem hiding this comment.
oh that's right, let's leave as ''
src/superstruct.ts
Outdated
| ...(validateAllFieldCriteria | ||
| ? { | ||
| types: { [type]: message || true }, | ||
| types: { [type!]: message || true }, |
bluebill1049
left a comment
bluebill1049
left a comment
There was a problem hiding this comment.
looks good, you want to publish a new patch?
|
Yes, I want to release a new patch! |
|
make sure push the tag and leave a release note as well :) 👍 |
|
What about the version? |
|
we can go |
|
I will release |
bluebill1049
left a comment
bluebill1049
left a comment
There was a problem hiding this comment.
just release a real version
npm version patch 0.0.4 👍
|
@bluebill1049 OK! I will do it. |
No description provided.