improve types

[kotarella1110]

No description provided.

[kotarella1110]

@bluebill1049 type may be undefined.
using ! to ignore type errors, how should I fix this?

[bluebill1049]

maybe we should omit the type if it can be undefined? your thoughts?

[kotarella1110]

@bluebill1049 If we omit type, I think you need to fix FieldError type as follows.

 export type FieldError = {
-  type: string;
+  type?: string;
   ref?: Ref;
   types?: MultipleFieldErrors;
   message?: Message;
   isManual?: boolean;
 }

I think it's better to use an empty string ('') to avoid this fix.

[bluebill1049]

oh that's right, let's leave as ''

[kotarella1110]

I will fix this!

[kotarella1110]

Same as above

[bluebill1049]

looks good, you want to publish a new patch?

[kotarella1110]

Yes, I want to release a new patch!

[bluebill1049]

make sure push the tag and leave a release note as well :) 👍

[kotarella1110]

What about the version?
1.0.0-beta.0 OK?

[bluebill1049]

we can go v1.0.0 if you are confident(this will be final release to work with v6).

[kotarella1110]

I will release 0.0.4-beta.0 👍

[bluebill1049]

just release a real version

npm version patch 0.0.4 👍

[kotarella1110]

@bluebill1049 OK! I will do it.