fix: isNameInFieldArray with names option #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuyaYoshioka
changed the title
YuyaYoshioka
changed the title
YuyaYoshioka
force-pushed
the
fix-issue-627
branch
from
70dfb84 to
1a3dc4b
Compare
YuyaYoshioka
commented
Sep 1, 2024
| @@ -38,4 +38,4 @@ export const toNestErrors = <TFieldValues extends FieldValues>( | |||
| const isNameInFieldArray = ( | |||
| names: InternalFieldName[], | |||
| name: InternalFieldName, | |||
| ) => names.some((n) => n.startsWith(name + '.')); | |||
| ) => names.some((n) => n.match(`^${name}\\.\\d+`)); | |||
There was a problem hiding this comment.
n should contain number in field array.
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Details
Because of #621, nested object error becomes not consistent when a key of the object is used in
option.names.To Reproduce
error.name.root.messagebecause"name"is used indepserror.name.messagechanges
isNameInFieldArraytoNestErrorswith names option