chore(deps-dev): bump typescript from 4.8.4 to 4.9.3 #1019
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
javascript
Codecov Report
@@ Coverage Diff @@
## master #1019 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 61 61
Lines 1041 1041
Branches 163 163
=======================================
Hits 1037 1037
Misses 2 2
Partials 2 2 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I will investigate this tomorrow. |
|
Relates to microsoft/TypeScript#51567 . We're getting hit by outdated types in our dependencies. This is fixed by recreating the lockfile. After that we're getting hit by the correctness updates to lib.d.ts, but luckily only in one mock function. |
|
And now our linter goes insane... Perhaps I should consider a more elegant approach than just regenerating the lockfile. |
|
Installing @types/node seems to be the best solution here. Also, during linting, this message now appears: Does not seem too bad to me. What does everybody think about this upgrade? |
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.8.4 to 4.9.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
This relates to the release of TypeScript 4.9. The correctness fixes related to lib.d.ts which were a part of this release broke the parameter type of this mock-function.
This reverts commit ab98ede.
This relates to the release of TypeScript 4.9, which broke our build. In the corresponding issue in the TypeScript repo, multiple solutions were proposed of which installing @types/node seems to work the best.
xobotyi
force-pushed
the
dependabot/npm_and_yarn/typescript-4.9.3
branch
from
250a684 to
4dcae8a
Compare
|
there were no need to add |
|
My first solution had that, but then the linter went insane. The same thing that we're seeing now. |
|
thats just a matter of changed types of testing library - im disabling false-positive linter for tests |
That linter raised false-positives errors
|
🎉 This PR is included in version 20.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Bumps typescript from 4.8.4 to 4.9.3.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)