Infinite re-rendering with hook

[dawsonc623]

Current behavior

I assume this behaviour is due to the functions coming back being new instances each time, but if I use the functions returned from the hook in a useEffect and add them to the dependency array, the useEffect fires infinitely. I can solve this by either not including them in the dependency array (not good practice) or wrapping them in a useCallback (not extraordinarily elegant, but better than the first option).

Expected behavior

The functions returned from the hook should be able to be placed in a dependency array of a useEffect without issue.

Repro steps

1. Grab the getItem function (for example) from the hook.
2. Create a useEffect hook that uses getItem.
3. Do something obvious in the effect that will signal each time it is called (such as a console.warn).
4. Add getItem to the dependency array of the useEffect.
5. Run the code.

Environment

• Async Storage version: ^1.7.1
• React-Native version: 0.59.5
• Platform tested: Android
• Logs/Error that are relevant: N/A

[krizzu]

Hey @dawsonc623

Please do not use those "hooks" - the implementation is broken and should be revisited. Here's a discussion regarding possible implementation

[dawsonc623]

Hello @krizzu

Thanks for the reply. I will avoid the hook for now and use the standard API.

Do you know when the hook might be looked at again?

[krizzu]

Haven't thought about specific date, but definitely should land in v2!

[gustavopch]

Wouldn't wrapping the functions with useCallback solve this?
https://github.com/react-native-community/async-storage/blob/e7e3a4fc8a662ccadfea16bedd645b4fdc20d23b/lib/hooks.js#L24-L27
I mean:

    getItem: useCallback((...args) => AsyncStorage.getItem(key, ...args), [key]),
    setItem: useCallback((...args) => AsyncStorage.setItem(key, ...args), [key]),
    mergeItem: useCallback((...args) => AsyncStorage.mergeItem(key, ...args), [key]),
    removeItem: useCallback((...args) => AsyncStorage.removeItem(key, ...args), [key]),

[arniu]

In my opinion, the hook here is to paint the lily.

[github-actions]

This issue has been marked as stale due to inactivity. Please respond or otherwise resolve the issue within 7 days or it will be closed.

[gustavopch]

Not stale.

[github-actions]

This issue has been marked as stale due to inactivity. Please respond or otherwise resolve the issue within 7 days or it will be closed.

[gustavopch]

Not stale.