Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Outdated typings #349

Closed
maximzhemerenko opened this issue May 9, 2020 · 1 comment
Closed

V2: Outdated typings #349

maximzhemerenko opened this issue May 9, 2020 · 1 comment

Comments

@maximzhemerenko
Copy link

Hi Guys, thanks a lot, I found v2 version of this library very useful for me, but noticed one problem.

Current behavior

Typescript typings are outdated with the current implementation.
For example, WebStorage class should have constructor, but typings not...

Expected behavior

Typings should be up to date.

Repro steps

Write a basic sample from the Readme file using typescript. Compilator says TS2554: Expected 0 arguments, but got 1..

Environment

"@react-native-community/async-storage-backend-web": "^2.0.0-rc.3"

  • React-Native version: - Not react native, "react": "^16.13.1",
  • Platform tested: - Web platform
  • Logs/Error that are relevant: TS2554: Expected 0 arguments, but got 1.

Who can help me, what can I do to find a workaround to this issue? I can help and make a merge request, but I don't know how to generate typing in a proper way? And how I can test is my fixes works fine?
I noticed that someone removed yarn generate:types in #216, but I do not completely understand how it does works)

@tido64
Copy link
Member

tido64 commented Oct 14, 2020

No longer applicable.

@tido64 tido64 closed this as completed Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants