Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump dependencies + update example setup #1164

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

chore: Bump dependencies + update example setup #1164

wants to merge 13 commits into from

Conversation

krizzu
Copy link
Member

@krizzu krizzu commented Dec 1, 2024

Summary

For each storage (default and sqlite), I'm "detaching" example RN app from the actual library implementation, by moving examples to be their own workspace. This makes it less noisy in terms of config files and what's actually is a part of lib or not.

Additionally, I bumped dependencies to almost latest. Tested most of it myself, to confirm it works, but had some issues with macOS RNCore dependency - will investigate it in a while. @tido64 could I ask you to check out the Windows example, if it works? 🙏

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1c2f396

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@krizzu krizzu force-pushed the chore/deps-and-examples branch 2 times, most recently from b2e7ed4 to 8ebe385 Compare December 2, 2024 11:09
@krizzu krizzu force-pushed the chore/deps-and-examples branch from 8ebe385 to 3b78ef5 Compare December 2, 2024 11:11
@krizzu krizzu force-pushed the chore/deps-and-examples branch from 807e315 to 7ca39b1 Compare January 1, 2025 20:05
@krizzu krizzu marked this pull request as ready for review January 2, 2025 18:45
@krizzu krizzu requested a review from tido64 as a code owner January 2, 2025 18:45
@krizzu
Copy link
Member Author

krizzu commented Jan 6, 2025

@tido64 test are passing now, ready for review 🙏

tido64
tido64 reviewed Jan 7, 2025
View reviewed changes
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move the example apps out of package folders entirely?

packages/default-storage/react-native.config.js Outdated Show resolved Hide resolved
packages/sqlite-storage/example/package.json Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@krizzu
Copy link
Member Author

krizzu commented Jan 14, 2025

@tido64 I don't mind moving examples out, but feels like they are good where they are now

@krizzu krizzu force-pushed the chore/deps-and-examples branch from a8491ff to b4fabf6 Compare January 14, 2025 08:28
tido64
tido64 reviewed Jan 14, 2025
View reviewed changes
packages/default-storage/example/metro.config.js Outdated Show resolved Hide resolved
packages/default-storage/example/app.json Show resolved Hide resolved
packages/default-storage/package.json
@@ -23,6 +23,7 @@
"Evan Bacon <bacon@expo.io> (https://github.com/evanbacon)",
"Tommy Nguyen <4123478+tido64@users.noreply.github.com> (https://github.com/tido64)"
],
"source": "src/index",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, which tool is using this field?

Copy link
Member Author

@krizzu krizzu Jan 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this in Bob, required to correctly find entry point for this module, in the example app

packages/sqlite-storage/example/metro.config.js Outdated Show resolved Hide resolved
@krizzu
Copy link
Member Author

krizzu commented Jan 27, 2025

@tido64 thank you for throughly done reviews 🙏

tido64
tido64 reviewed Jan 27, 2025
View reviewed changes
packages/default-storage/example/package.json Outdated
@@ -35,7 +36,6 @@
"@react-native-community/cli-platform-android": "^15.0.0",
"@react-native-community/cli-platform-ios": "^15.0.0",
"@react-native/babel-preset": "^0.76.0",
"@react-native/metro-config": "^0.76.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need this as it contains the default config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tido64 tido64 tido64 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krizzu @tido64