Skip to content

[Fix] Use same directory name for storage, couple of fixes #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2019
Merged

[Fix] Use same directory name for storage, couple of fixes #46

merged 2 commits into from
Mar 26, 2019

Conversation

krizzu
Copy link
Member

@krizzu krizzu commented Mar 25, 2019 •
edited
Loading

Summary:

Couple of things:

  • Example was unlinked, so linked it back
  • Uses same directory name as internal Async Storage, so transition is smooth
  • Removed reference to RN's internal Async Storage - this sometimes thrown error .multiMerge error
  • Throws error when not linked

Fixes #40
Potentially fixes #44

Test Plan:

Green CI

@krizzu krizzu added platform: iOS This is iOS specific platform: Android This is Android specific labels Mar 25, 2019
@krizzu krizzu merged commit 547445c into master Mar 26, 2019
@krizzu krizzu deleted the ios-storage-location branch March 26, 2019 16:39
@krizzu
Copy link
Member Author

krizzu commented Mar 26, 2019

🎉 This PR is included in version 1.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@krizzu krizzu mentioned this pull request Mar 26, 2019
Merged
@krizzu krizzu removed the platform: Android This is Android specific label Apr 3, 2019
@krizzu krizzu mentioned this pull request Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
platform: iOS This is iOS specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't run on Android with RN > 0.58 [iOS] Cannot get data set by react-native's AsyncStorage
1 participant
@krizzu